Fix: LCFS - BUG AG Grid copy and paste function for Fuel codes table … #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on IDIR side not functioning #1302
added 2 commits
December 10, 2024 04:16
areyeslo
reviewed
Dec 10, 2024
| @@ -229,10 +231,12 @@ const AddEditFuelCodeBase = () => { | |||
| const errMsg = `Error updating row: ${ | |||
| fieldLabels.length === 1 ? fieldLabels[0] : '' | |||
| } ${message}` | |||
|
|
|||
| updatedData.validationMsg = errMsg | |||
There was a problem hiding this comment.
Tested and received 422, when processing the date fields. They are not in correct format. Then, needed to give a proper format. Something like this:
// Format date fields to ISO 8601
const formattedData = { ...params.node.data };
dateFields.forEach((field) => {
if (formattedData[field]) {
const date = new Date(formattedData[field]);
if (!isNaN(date.getTime())) {
formattedData[field] = date.toISOString().split('T')[0]; // Keep only the YYYY-MM-DD part
}
}
});
let updatedData = Object.entries(formattedData)
After that the request passes the schema validation, it can start executing create_fuel_code. However, an error is raised: ValueError: Invalid transport mode: Truck
There was a problem hiding this comment.
Thanks for your review @areyeslo ,
- yes, from excel , date needs to be copied in proper format otherwise it throws error.
- Truck is no longer among the valid transport mode in the database. hence value error.
areyeslo
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on IDIR side not functioning #1302