Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Replace Typography with BCTypography for Design Consistency - #1341 #1435

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Refactor: Replace Typography with BCTypography for Design Consistency - #1341 #1435

merged 3 commits into from
Dec 11, 2024

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR updates all Typography instances to BCTypography for consistent design and reduced redundant styling.

Closes #1341

AlexZorkin
AlexZorkin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to test every single component, but if all tests are passing and there's no obvious visible differences then all good 👍

@github-actions GitHub Actions
Copy link

Backend Test Results

493 tests  ±0   493 ✅ ±0   1m 48s ⏱️ +3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 769a7c5. ± Comparison against base commit 85c783d.

@github-actions GitHub Actions
Copy link

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ -1s
388 tests ±0  368 ✅ ±0  20 💤 ±0  0 ❌ ±0 
390 runs  ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 769a7c5. ± Comparison against base commit 85c783d.

@hamed-valiollahi
Copy link
Collaborator Author

Hard to test every single component, but if all tests are passing and there's no obvious visible differences then all good 👍

Thank you, Alex, for reviewing my PR. I’ve checked every single change!

@hamed-valiollahi hamed-valiollahi merged commit aa0c65d into release-0.2.0 Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexZorkin AlexZorkin AlexZorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCFS - Replace Typography with BCTypography Across Components for Consistency
2 participants
@hamed-valiollahi @AlexZorkin