Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Provide default value to organization_name field in FSE on creation #1447

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

areyeslo
Copy link
Collaborator

Provide default value for existing records in FSE.

@areyeslo areyeslo changed the title Provide default value to organization_name field in FSE on creation hotfix: Provide default value to organization_name field in FSE on creation Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   38s ⏱️ ±0s
390 tests ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 
392 runs  ±0  372 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 926c881. ± Comparison against base commit 31acf1f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2024

Backend Test Results

493 tests  ±0   491 ✅ ±0   1m 43s ⏱️ -5s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 926c881. ± Comparison against base commit 31acf1f.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo requested a review from AlexZorkin December 12, 2024 20:46
Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing migration files shouldn't be modified, as changes won't reflect in production. Please create a new migration file instead. Let me know if I’m mistaken! Thank you!

@areyeslo
Copy link
Collaborator Author

because if a migration hasn't run in test and it is still in dev. So the migration will be applied in test and in Prod when we will go live.

@areyeslo areyeslo merged commit cbc1888 into release-0.2.0 Dec 12, 2024
10 checks passed
@hamed-valiollahi
Copy link
Collaborator

That makes sense! Thank you for the clarification, Arturo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants