Feat: Enforce mandatory fuel code validation for schedules - 1429 #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend Test Results493 tests ±0 491 ✅ ±0 1m 48s ⏱️ -2s For more details on these failures, see this check. Results for commit 3caa3d6. ± Comparison against base commit c16d7cb. ♻️ This comment has been updated with latest results. |
areyeslo
reviewed
Dec 13, 2024
| @@ -1,4 +1,6 @@ | |||
| import logging | |||
| import os | |||
| import debugpy | |||
There was a problem hiding this comment.
Do we need these new imports?
areyeslo
requested changes
Dec 13, 2024
Thanks for the code review. We need these imports for backend debugging purposes. It looks like they were accidentally removed. They enable remote debugging in development if needed. Please refer to line 111 of this file for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements logic to enforce mandatory fuel code selection in schedules when "Fuel code - section 19 (b) (i)" is chosen.
Closes #1429