Fix: Resolve fuel code increment and row duplication order issue - #1303 #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexZorkin
requested changes
Dec 19, 2024
|
@AlexZorkin Thank you for the code review! Do you think it would be a good idea to cover this with e2e tests? If so, should I create a new ticket for it? |
|
Sure I will create a followup ticket. |
AlexZorkin
approved these changes
Dec 20, 2024
|
Thank you, Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the fuel code number does not increment after using the duplicate row function and ensures the duplicated row is placed below the existing record, caused by a conflict with #1446.
Closes #1303