Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEVA - update credit transfer unit tests #2329

Open
1 task
tim738745 opened this issue Oct 23, 2024 · 0 comments
Open
1 task

ZEVA - update credit transfer unit tests #2329

tim738745 opened this issue Oct 23, 2024 · 0 comments
Assignees
Labels
Low Low priority Tech Debt

Comments

@tim738745
Copy link
Collaborator

Describe the task
The api/fixture/test/0003_add_bceid_users.py file should be updated so that each test user is assigned a distinct organization; currently, 2 distinct users can be assigned the same organization and if that happens, some credit transfer tests will fail.

Purpose
Makes it so that our unit tests don't fail intermittently.

Acceptance Criteria

  • The credit transfer unit tests pass.

Developer Checklist
(1) Update the code in the file mentioned above (0003_add_bceid_users.py) in the manner specified above.
(2) Update the test_list_transfer and test_transfer_pass tests in test_credit_transfers.py so that they don't use transaction.on_commit() (that is there because, earlier, that was Tim's suggested solution to the intermittent failure of these tests, but it actually makes it so that the assertions don't run because the transactions are never actually committed!).

@shayjeff shayjeff added Tech Debt Low Low priority labels Dec 11, 2024
@jdtoombs jdtoombs self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Low priority Tech Debt
Projects
None yet
Development

No branches or pull requests

3 participants