Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEVA - Flagging Duplicate VINs in BCeID Spreadsheet Uploads to Prevent Error 31 (duplicate VINs) #2363

Closed
4 tasks done
shayjeff opened this issue Nov 21, 2024 · 2 comments
Closed
4 tasks done
Assignees
Labels
Medium Medium Priority Task Any work that does not directly impact the user Tested :) Passed testing

Comments

@shayjeff
Copy link
Collaborator

shayjeff commented Nov 21, 2024

Describe the task
Implement a feature in the ZEVA system that flags duplicate VINs in the spreadsheet uploads for BCeID users. The feature will prevent uploads containing duplicate VINs from being processed until the duplicates are removed.

Purpose
This task will improve efficiency and user experience by preventing duplicate VINs from being submitted in the first place. It eliminates the need for IDIR users returning the duplicate VINs and for suppliers to resubmit them in new credit applications.

Acceptance Criteria

  • Add functionality to flag duplicate VINs during the spreadsheet upload process for BCeID users.
  • Halt the upload if duplicate VINs are detected and display a clear error message to the user.
  • Include an error message instructing users to remove duplicate VINs before resubmitting the spreadsheet.
  • Confirm the flagging feature works smoothly within the existing spreadsheet upload process for BCeID users.

Additional context

  • Error code 31 occurs when a supplier submits the same VIN twice, and both are flagged as duplicates.
  • Currently, there is no way to validate one of these VINs within the system; IDIR users must return the VINs, requiring BCeID users to
    resubmit them in a new credit application.
@shayjeff shayjeff added Task Any work that does not directly impact the user High High priority ticket but not critical at this time labels Nov 21, 2024
@shayjeff shayjeff changed the title ZEVA - Feature for Validating Error Code 31 (Duplicate VINs) ZEVA - Flagging Duplicate VINs in BCeID Spreadsheet Uploads to Prevent Error 31 (duplicate VINs) Nov 22, 2024
@shayjeff shayjeff added Medium Medium Priority and removed High High priority ticket but not critical at this time labels Nov 22, 2024
@tim738745
Copy link
Collaborator

Can look at frontend/src/salesforecast/components/RecordsUpload.js to see how we can parse spreadsheets in the user's browser using the xlsx library.

@emi-hi emi-hi self-assigned this Nov 28, 2024
@shayjeff shayjeff added the Tested :) Passed testing label Jan 9, 2025
@shayjeff
Copy link
Collaborator Author

Tested and approved. All criteria met with no issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Medium Priority Task Any work that does not directly impact the user Tested :) Passed testing
Projects
None yet
Development

No branches or pull requests

3 participants