Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New transaction page - disable "Save" Button Until All Required Fields Are Completed #2380

Open
4 tasks
Lalita-Lala opened this issue Dec 14, 2024 · 2 comments
Open
4 tasks
Assignees
Labels
Medium Medium Priority Task Any work that does not directly impact the user

Comments

@Lalita-Lala
Copy link
Collaborator

Describe the task
When the user clicks on the “New Transaction” button on Credit Agreements page, they are redirected to the page for creating a new transaction. On this page, the "Save" button is immediately enabled, even before any required fields have been completed. This behavior is both confusing for the user and allows them to save an agreement without providing the necessary information in mandatory fields, such as Transaction Date, Transaction Type, and Vehicle Supplier.
This is incorrect, as incomplete data should not be saved because for example if the credit agreement does not have a date attached to it, the director gets an error when they try to issue credits. The "Save" button should only become enabled after all required fields are properly filled out.

Mockups and prototypes
Proto
Mockups

Purpose
To ensure that users cannot save transactions with incomplete or missing required information. This change aims to improve data accuracy, reduce confusion, and prevent errors when agreements are submitted with missing data.

Acceptance Criteria

  • The "Save" button is disabled by default when the user enters the “New transaction” agreement page.
  • The "Save" button becomes enabled only after the user completes all required fields, including Transaction Date, Transaction Type, and Vehicle Supplier.
  • A tool-tip is displayed when hovering over the disabled "Save" button with the message: “Please fill in all the required fields to enable the “Save” button.”
  • Incomplete agreements cannot be saved or submitted for next step.
@Lalita-Lala
Copy link
Collaborator Author

This ticket was created based on this 2301

@ArawuSamuel1 ArawuSamuel1 added Task Any work that does not directly impact the user Medium Medium Priority labels Dec 18, 2024
@rogerlcleung rogerlcleung self-assigned this Dec 19, 2024
@rogerlcleung
Copy link
Collaborator

Changes in PR #2406 also include disabling the "Submit to Director" button when there is any zero credit entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Medium Priority Task Any work that does not directly impact the user
Projects
None yet
Development

No branches or pull requests

3 participants