Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase transactions during chain reorganizations perpetually pending #656

Open
braydonf opened this issue Dec 21, 2018 · 0 comments
Open
Labels
bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request mining Related to mining, Proof of Work wallet Wallet related

Comments

@braydonf
Copy link
Contributor

Versions
bcoin v1.0.2

Expected

Either the mining coinbase transaction is shown as unconfirmed in a wallet after a reorganization or be removed. The prior is currently the case.

Actual

Coinbase transactions will perpetually become unconfirmed during a chain reorganization with a competing chain. These transactions will then be attempted to be broadcast to peers upon a rebroadcast attempt (this has been fixed in #605).

Reproduce

There is a test case in #605 that generates reorgs and coinbase transactions are unconfirmed.

Workaround

Use abandontransaction to remove the transaction that will never be confirmed.

@pinheadmz pinheadmz added bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request labels Jan 21, 2019
@braydonf braydonf added the wallet Wallet related label Feb 6, 2019
@braydonf braydonf added the mining Related to mining, Proof of Work label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request mining Related to mining, Proof of Work wallet Wallet related
Projects
None yet
Development

No branches or pull requests

2 participants