Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconfirmed coinbase transactions will be rebroadcast #661

Open
braydonf opened this issue Dec 24, 2018 · 0 comments
Open

Unconfirmed coinbase transactions will be rebroadcast #661

braydonf opened this issue Dec 24, 2018 · 0 comments
Labels
bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request wallet Wallet related
Milestone

Comments

@braydonf
Copy link
Contributor

Versions
bcoin v1.0.2

Expected

Resending pending transactions to not broadcast coinbase transactions that will get a node banned from peers.

Actual

If there is a reorg that causes a coinbase transaction to become unconfirmed/pending and the wallet resends any pending transactions to peers, it will attempt to broadcast the coinbase transaction.

Solution

In lib/wallet/wallet.js check that a transaction !wtx.tx.isCoinbase() before adding to the array of transactions to be rebroadcast. This has been fixed in #605 with braydonf@3e65f93#diff-10775d9a238b8247721a7dc0600d5a8a

@pinheadmz pinheadmz added bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request labels Jan 21, 2019
@braydonf braydonf added the wallet Wallet related label Feb 6, 2019
@braydonf braydonf added this to the v3.0.0 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect behavior has PR Issue is addressed with a pull request wallet Wallet related
Projects
None yet
Development

No branches or pull requests

2 participants