Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BDF/BDF+ #33

Closed
jrevels opened this issue May 20, 2020 · 1 comment · Fixed by #46
Closed

Support BDF/BDF+ #33

jrevels opened this issue May 20, 2020 · 1 comment · Fixed by #46

Comments

@jrevels
Copy link
Member

jrevels commented May 20, 2020

BDF/BDF+ is essentially "24 bit EDF/EDF+": https://www.teuniz.net/edfbrowser/bdfplus%20format%20description.html

We could add a simple bdf flag to the File constructor (e.g. File(io, bdf=true)) and make sure to handle BDF-specific quirks on read/write. We should probably define a simple Int24 primitive type internally for storage, and decode can handle it during conversion to floating point whenever any actual computation needs to be performed.

@palday
Copy link
Member

palday commented Jun 2, 2020

I think BDF also limits some other things (e.g. requires constant sampling rate and includes a status channel), but it's the native format of Biosemi amplifiers, so we wind up supporting a huge class of research equipment. There's also GDF ..... There's a little bit on this over at bids-standard/pyedf#2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants