fix record type version integer parsing (#68)

beacon-biosignals · Nov 10, 2022 · 68ffeb3 · 68ffeb3 · jrevels · Nov 10, 2022
1 parent 02cfd2b
commit 68ffeb3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Legolas"
 uuid = "741b9549-f6ed-4911-9fbf-4a1c0c97f0cd"
 authors = ["Beacon Biosignals, Inc."]
-version = "0.5.3"
+version = "0.5.4"
 
 [deps]
 Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"

diff --git a/src/schemas.jl b/src/schemas.jl
@@ -560,7 +560,7 @@ function _generate_record_type_definitions(schema_version::SchemaVersion, record
 end
 
 function _parse_record_type_symbol(t::Symbol)
-    pv = split(string(t), 'V')
+    pv = rsplit(string(t), 'V'; limit=2)
     if length(pv) == 2
         p, v = pv
         p = Symbol(p)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -221,6 +221,15 @@ end
 
 @schema "test.new" New
 
+@schema "test.has-a-v1-in-the-middle" HasAV1InTheMiddle
+@version HasAV1InTheMiddleV1 begin
+    id::UUID
+end
+@version HasAV1InTheMiddleV2 begin
+    id::UUID
+    x::Int
+end
+
 @testset "`Legolas.@version` and associated utilities for declared `Legolas.SchemaVersion`s" begin
     @testset "Legolas.SchemaVersionDeclarationError" begin
         @test_throws SchemaVersionDeclarationError("malformed or missing declaration of required fields") eval(:(@version(NewV1, $(Expr(:block, LineNumberNode(1, :test))))))