Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadTheDocs documentation #13

Open
LecrisUT opened this issue Jun 14, 2023 · 10 comments
Open

ReadTheDocs documentation #13

LecrisUT opened this issue Jun 14, 2023 · 10 comments

Comments

@LecrisUT
Copy link

LecrisUT commented Jun 14, 2023

ReadTheDocs supports subprojects, meaning that the rtd pages built on this repo can be custom pages on either beakerlib.readthedocs.io or tmt.readthedocs.io.

This is helpful because there will be a central place to find all of the libraries.

Pinging: @lukaszachy @psss @sopos

@psss
Copy link
Member

psss commented Jun 21, 2023

Nice idea! Sounds good to me to provide the list of available beakerlib libraries directly in the documentation. I'd say beakerlib.readthedocs.io would be a better choice for the lib details and add a link to the page from the tmt documentation.

@LecrisUT
Copy link
Author

Great to hear :). Can you enable RTD on tmt PRs so I can test the integration later on?

@psss
Copy link
Member

psss commented Jun 21, 2023

This is done using the github action?
https://github.com/marketplace/actions/sphinx-docs-build-with-readthedocs-docker

@LecrisUT
Copy link
Author

No, it's in the RTD configuration of the tmt project. I am still trying to get RTD to work with GH actions: readthedocs/actions#27.

Read the docs configuration page

Screenshot_20230621_150256

@psss
Copy link
Member

psss commented Jun 21, 2023

Thanks for the pointer. Should be enabled now.

@LecrisUT
Copy link
Author

Oh I forgot to mention (had this happen to me several times), don't forget to hit save :D.

@psss
Copy link
Member

psss commented Jun 21, 2023

Oh I forgot to mention (had this happen to me several times), don't forget to hit save :D.

Hm, I've updated, and saved, but no new status appears in the fresh pull requests. Not even after adding new commits. Is there anything missing in the tmt repo?

@LecrisUT
Copy link
Author

I think it doesn't add for current PRs unless they are closed and reopened. But I tried that with teemtee/tmt#2098 and I don't see any changes here. The only other thing I can think of is to check the webhook settings and recent deliveries there. Make sure pull_request events are sent.

@psss
Copy link
Member

psss commented Jun 21, 2023

The only other thing I can think of is to check the webhook settings and recent deliveries there. Make sure pull_request events are sent.

Yes, that was it. Thanks for the hint!

@LecrisUT
Copy link
Author

Great, it doesn't even require closing and reopening PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants