Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tailwind #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Tailwind #6

wants to merge 1 commit into from

Conversation

kamalogudah
Copy link

@kamalogudah kamalogudah commented Feb 14, 2021

This adds tailwind to the Repo with an example component in the landing page.

Proposed solution

Tradeoffs

Testing Done

None.

Changelog updated?

No.

@kamalogudah kamalogudah linked an issue Feb 14, 2021 that may be closed by this pull request
"optimize-css-assets-webpack-plugin": "^5.0.1",
"postcss": "^8.2.6",
"postcss-loader": "^4.2.0",
"sass-loader": "^8.0.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned why sass was included in the project when most of what it offers can be achieved using postcss and plugins (postcss-nested, postcss-import, etc.).

Copy link
Member

@manuelgeek manuelgeek Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind CSS uses scss to build it it's classes @heywhy

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not compulsory, I use tailwindcss without any preprocessor like sass, less, stylus and so on. And the reason I don’t use any preprocessor is because most of what they provide can be achieved using a corresponding postcss plugin.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know if I’m allowed to make modification to this same branch/PR. I can make the modifications needed

@@ -1,91 +1,5 @@
/* This file is for your main application css. */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel most of the classes defined in this file will be useful since we are working with LiveView. What I will suggest is to create a new file liveview.css and import it in app.css (see https://github.com/beamkenya/beamkenya_site/pull/6/files#r579540971). And a new file, called components.css, can be created then move the import of tailwind directives into, that way the app.css is less bloated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, like for tailwind css, a separate file will work, the tailwind directives can grow with time with much customizations and creating custom components as we grow

@manuelgeek
Copy link
Member

@kamalogudah view suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tailwind css library
3 participants