Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Grid hashable if T is hashable #44

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

henryiii
Copy link
Contributor

I think this should work to make this hashable if the element type is hashable. Closes #43.

@becheran
Copy link
Owner

Thanks for the pull request. It seems not to work though if not using the std lib. Which is supported by this crate. See failing pipeline with --no-default-features set.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Contributor Author

henryiii commented Dec 15, 2023

I think that fixes it. I didn't have a hash impl (std::collections::hash_map::DefaultHasher) to use without std, so didn't test it without std. But it compiles without std now and works with std when I try locally without default features.

@becheran becheran merged commit 27c078c into becheran:master Dec 16, 2023
3 checks passed
@henryiii henryiii deleted the henryiii/feat/hash branch December 16, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Hash
2 participants