From 0fa5d02ec03a53909de5519b0a2aa8f5f38065de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rogger=20andr=C3=A9=20valverde=20flores?= Date: Tue, 16 Feb 2021 23:10:33 -0500 Subject: [PATCH 1/5] fix(dashboard): refresh page when adding a new job --- public/dashboard.js | 1 + 1 file changed, 1 insertion(+) diff --git a/public/dashboard.js b/public/dashboard.js index 9d28d768..c806edfa 100644 --- a/public/dashboard.js +++ b/public/dashboard.js @@ -176,6 +176,7 @@ $(document).ready(() => { .done(() => { alert('Job successfully added!'); localStorage.removeItem('arena:savedJob'); + window.location.reload(); }) .fail((jqXHR) => { window.alert('Failed to save job, check console for error.'); From 78cf7c86486bc3729e53fa5fb75001996bc6f987 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rogger=20andr=C3=A9=20valverde=20flores?= Date: Tue, 16 Feb 2021 23:53:45 -0500 Subject: [PATCH 2/5] refactor(dashboard): change text on add job button --- public/dashboard.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/public/dashboard.js b/public/dashboard.js index c806edfa..06a8b736 100644 --- a/public/dashboard.js +++ b/public/dashboard.js @@ -148,7 +148,11 @@ $(document).ready(() => { }); $('.js-toggle-add-job-editor').on('click', function () { - $('.jsoneditorx').toggleClass('hide'); + const addJobText = $('.js-toggle-add-job-editor').text(); + const shouldHide = addJobText !== 'Add Job'; + $('.jsoneditorx').toggleClass('hide', shouldHide); + $('.js-toggle-add-job-editor').text('Cancel'); + const job = localStorage.getItem('arena:savedJob'); if (job) { const { name, data } = JSON.parse(job); From 67eb7589f872d117fe619c1305be93429479c64b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rogger=20andr=C3=A9=20valverde=20flores?= Date: Wed, 17 Feb 2021 00:20:10 -0500 Subject: [PATCH 3/5] refactor(dashboard): change text on add job button depending on shouldHide --- public/dashboard.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/public/dashboard.js b/public/dashboard.js index 06a8b736..17289def 100644 --- a/public/dashboard.js +++ b/public/dashboard.js @@ -150,8 +150,9 @@ $(document).ready(() => { $('.js-toggle-add-job-editor').on('click', function () { const addJobText = $('.js-toggle-add-job-editor').text(); const shouldHide = addJobText !== 'Add Job'; + const newAddJobText = shouldHide ? 'Cancel' : 'Add Job'; $('.jsoneditorx').toggleClass('hide', shouldHide); - $('.js-toggle-add-job-editor').text('Cancel'); + $('.js-toggle-add-job-editor').text(newAddJobText); const job = localStorage.getItem('arena:savedJob'); if (job) { From 5b55500b08e01339f463468d89794302881f2e2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rogger=20andr=C3=A9=20valverde=20flores?= Date: Wed, 17 Feb 2021 20:44:48 -0500 Subject: [PATCH 4/5] refactor(dashboard): delete window location reload --- public/dashboard.js | 1 - 1 file changed, 1 deletion(-) diff --git a/public/dashboard.js b/public/dashboard.js index 17289def..829b318f 100644 --- a/public/dashboard.js +++ b/public/dashboard.js @@ -181,7 +181,6 @@ $(document).ready(() => { .done(() => { alert('Job successfully added!'); localStorage.removeItem('arena:savedJob'); - window.location.reload(); }) .fail((jqXHR) => { window.alert('Failed to save job, check console for error.'); From 5722b551be4b7142806d39cc4c4297eb19cd3f13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?rogger=20andr=C3=A9=20valverde=20flores?= Date: Thu, 18 Feb 2021 10:28:17 -0500 Subject: [PATCH 5/5] fix(dashboard): change shouldHide condition --- public/dashboard.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/dashboard.js b/public/dashboard.js index 829b318f..499b9ef2 100644 --- a/public/dashboard.js +++ b/public/dashboard.js @@ -149,9 +149,9 @@ $(document).ready(() => { $('.js-toggle-add-job-editor').on('click', function () { const addJobText = $('.js-toggle-add-job-editor').text(); - const shouldHide = addJobText !== 'Add Job'; - const newAddJobText = shouldHide ? 'Cancel' : 'Add Job'; - $('.jsoneditorx').toggleClass('hide', shouldHide); + const shouldNotHide = addJobText === 'Add Job'; + const newAddJobText = shouldNotHide ? 'Cancel' : 'Add Job'; + $('.jsoneditorx').toggleClass('hide', !shouldNotHide); $('.js-toggle-add-job-editor').text(newAddJobText); const job = localStorage.getItem('arena:savedJob');