Skip to content

Commit

Permalink
removed cruft of checks for pre ios17
Browse files Browse the repository at this point in the history
app was bumped to target ios17 with #484 and thus
the code no longer need to check manually for iOS 14, 15, or 16
  • Loading branch information
krugerk committed Nov 26, 2024
1 parent 05d65e7 commit 635dd1b
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 25 deletions.
12 changes: 4 additions & 8 deletions BeeKit/HeathKit/HealthKitConfig.swift
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,14 @@ public class HealthKitConfig : NSObject {
QuantityHealthKitMetric(humanText: "Vitamin E", databaseString: "dietaryVitaminE", category: .Nutrition, hkQuantityTypeIdentifier: .dietaryVitaminE),
QuantityHealthKitMetric(humanText: "Vitamin K", databaseString: "dietaryVitaminK", category: .Nutrition, hkQuantityTypeIdentifier: .dietaryVitaminK),
QuantityHealthKitMetric(humanText: "Water", databaseString: "water", category: .Nutrition, hkQuantityTypeIdentifier: .dietaryWater),

// Sleep
TimeInBedHealthKitMetric(humanText: "Time in bed", databaseString: "timeInBed", category: .Sleep),
TimeAsleepHealthKitMetric(humanText: "Time asleep", databaseString: "timeAsleep", category: .Sleep),


QuantityHealthKitMetric(humanText: "Time in Daylight", databaseString: "timeInDaylight", category: .Other, hkQuantityTypeIdentifier: .timeInDaylight),
]

if #available(iOS 17, *) {
// Other
allMetrics.append(QuantityHealthKitMetric(humanText: "Time in Daylight", databaseString: "timeInDaylight", category: .Other, hkQuantityTypeIdentifier: .timeInDaylight))
}


return allMetrics
}()
}
11 changes: 1 addition & 10 deletions BeeKit/HeathKit/TotalSleepMinutes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,14 @@ enum SleepResolution {
}

func isRelevantToSleep(_ sample: HKCategorySample) -> Bool {
var relevantValues: [HKCategoryValueSleepAnalysis]
if #available(iOS 16.0, *) {
relevantValues = [
let relevantValues: [HKCategoryValueSleepAnalysis] = [
HKCategoryValueSleepAnalysis.awake,
HKCategoryValueSleepAnalysis.asleepUnspecified,
HKCategoryValueSleepAnalysis.asleepREM,
HKCategoryValueSleepAnalysis.asleepDeep,
HKCategoryValueSleepAnalysis.asleepCore,
HKCategoryValueSleepAnalysis.asleepUnspecified
]
} else {
// Fallback on earlier versions
relevantValues = [
HKCategoryValueSleepAnalysis.awake,
HKCategoryValueSleepAnalysis.asleep
]
}

return relevantValues.contains(HKCategoryValueSleepAnalysis(rawValue: sample.value)!)
}
Expand Down
1 change: 0 additions & 1 deletion BeeSwift/AddDataIntentHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import Foundation
import Intents
import BeeKit

@available(iOS 14.0, *)
class AddDataIntentHandler: NSObject, AddDataIntentHandling {
func resolveValue(for intent: AddDataIntent) async -> AddDataValueResolutionResult {
if let value = intent.value {
Expand Down
2 changes: 0 additions & 2 deletions BeeSwift/LogReader.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
import Foundation
import OSLog


@available(iOS 15.0, *)
class LogReader {
private var allMessagesTask: Task<[OSLogEntryLog], Never>!

Expand Down
2 changes: 0 additions & 2 deletions BeeSwift/Settings/LogsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import Foundation
import OSLog
import OrderedCollections


@available(iOS 15.0, *)
class LogsViewController: UIViewController {

let logTextView = UITextView()
Expand Down
1 change: 0 additions & 1 deletion BeeSwiftIntents/IntentHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import Foundation
import Intents

@available(iOS 14.0, *)
class IntentHandler : INExtension {
override func handler(for intent: INIntent) -> Any? {
AddDataIntentHandler()
Expand Down
1 change: 0 additions & 1 deletion BeeSwiftTests/LogReaderTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import OSLog

@testable import BeeSwift

@available(iOS 15.0, *)
final class LogReaderTests: XCTestCase {
private let logger = Logger(subsystem: "com.beeminder.beeminder", category: "LogReaderTests")

Expand Down

0 comments on commit 635dd1b

Please sign in to comment.