gallery goal cell's thumbnail image has different colored border than safesum #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
safesum color and thumbnail border were both too similar and different on light for orange
This implementation uses the standard graph image in place of the thumbnail on the gallery, drawing itself a border around the image. This has the added benefit of the graph being loaded already when the user navigates to the corresponding goal screen. It has the downside of grabbing the larger files (full graph image rather than smaller thumbnail). Also, the thumbnail image, designed for use on the website, contained just the graph without its x and y axes' labels and values.For UI changes including screenshots of before and after is great.
before
see #573
after (username/goalname-thumb.png)
red
orange
blue
green
forest green
after (username/goalname.png)
red
orange
blue
green
forest green
Validation
viewed gallery in simulator
Fixes #573