Fix GoalViewController memory leak #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theospears
changed the title
krugerk
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were retaining references to GoalViewController meaning it was not correctly cleaned up when leaving the view. There were two causes of this.
GoalViewControllerandDatapointTableController(fixed via weak ref)Fixes #590
Validation
Ran the app in the simulator. Navigated to the goal view and back several times. Ran the XCode memory graph debugger.
Before this patch: Observed many GoalViewController still in memory
After this patch: No copies of the class in memory
Logged out and logged into the app. Observed there was no longer a crash reading goal objects.