Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove camera calculations once OpenUSD/#2556 is fixed #2

Open
hybridherbst opened this issue Sep 12, 2023 · 2 comments
Open

Remove camera calculations once OpenUSD/#2556 is fixed #2

hybridherbst opened this issue Sep 12, 2023 · 2 comments
Assignees

Comments

@hybridherbst
Copy link
Contributor

usdrecord should already calculate bounds and clipping, however there seems to be a bug with small objects where clipping planes aren't set correctly:
PixarAnimationStudios/OpenUSD#2556

Once that is fixed, the code here can be simplified (e.g. camera calculations could be optional if more control is needed).

@hybridherbst
Copy link
Contributor Author

This one seems to be fixed now:

Might be worth a try and

  • either remove custom camera calculations from this repo
  • or report an issue with what doesn't work with the usdrecord calculations

@beersandrew beersandrew self-assigned this May 2, 2024
@beersandrew
Copy link
Owner

This one seems to be fixed now:

Might be worth a try and

  • either remove custom camera calculations from this repo
  • or report an issue with what doesn't work with the usdrecord calculations

usdrecord by default does frame the subject well, not sure in which cases this was not working in the past. but the one factor here is that usdrecord is taking the image as if it's being seen for the first time in usdview. this usdview camera is not square so i think for the purposes of thumbnails there still needs to be camera logic to frame the subject and adjust field of view to produce a square view of the subject. this makes me think there isn't anything to change here. let me know if that makes sense or if you had some other ideas for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants