From 504d3dc8cd03684ce9353117df80fb5323612c28 Mon Sep 17 00:00:00 2001 From: Jioo Date: Mon, 18 Nov 2024 23:22:21 +0900 Subject: [PATCH] fix: modify nickname test code --- .../omokwang/nickname/ui/NicknameController.java | 6 +++--- .../omokwang/user/domain/UserServiceTest.java | 15 +++++++-------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/main/java/begin_a_gain/omokwang/nickname/ui/NicknameController.java b/src/main/java/begin_a_gain/omokwang/nickname/ui/NicknameController.java index 4591773..5225f0d 100644 --- a/src/main/java/begin_a_gain/omokwang/nickname/ui/NicknameController.java +++ b/src/main/java/begin_a_gain/omokwang/nickname/ui/NicknameController.java @@ -14,8 +14,8 @@ import java.util.Optional; import lombok.RequiredArgsConstructor; import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.PatchMapping; import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.PutMapping; import org.springframework.web.bind.annotation.RequestBody; import org.springframework.web.bind.annotation.RestController; @@ -31,7 +31,7 @@ public class NicknameController { content = @Content(schema = @Schema(implementation = NicknameResponse.class))), @ApiResponse(responseCode = "400", description = "Invalid nickname or nickname already taken", content = @Content) }) - @PostMapping("/validations/nicknames") + @PostMapping("/nicknames/validations") public ResponseEntity checkNickname(@RequestBody NicknameRequest nicknameRequest) { Optional validationError = nicknameService.validateNickname(nicknameRequest.getNickname()); @@ -43,7 +43,7 @@ public ResponseEntity checkNickname(@RequestBody NicknameRequest nicknam @ApiResponses(value = { @ApiResponse(responseCode = "200", description = "Nickname updated successfully") }) - @PatchMapping("/nickname") + @PutMapping("/nicknames") public ResponseEntity updateNickname(@RequestBody NicknameRequest nicknameRequest) { final long userId = SecurityUtil.getCurrentUserId(); String nickname = nicknameRequest.getNickname(); diff --git a/src/test/java/begin_a_gain/omokwang/user/domain/UserServiceTest.java b/src/test/java/begin_a_gain/omokwang/user/domain/UserServiceTest.java index 260eec1..d153bbe 100644 --- a/src/test/java/begin_a_gain/omokwang/user/domain/UserServiceTest.java +++ b/src/test/java/begin_a_gain/omokwang/user/domain/UserServiceTest.java @@ -3,8 +3,8 @@ import static org.assertj.core.api.AssertionsForClassTypes.assertThat; import static org.mockito.Mockito.when; +import begin_a_gain.omokwang.nickname.application.NicknameService; import begin_a_gain.omokwang.user.repository.UserRepository; -import begin_a_gain.omokwang.user.service.UserService; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -19,7 +19,7 @@ public class UserServiceTest { @InjectMocks - private UserService userService; + private NicknameService nicknameService; @Mock private UserRepository userRepository; @@ -28,9 +28,9 @@ public class UserServiceTest { @DisplayName("닉네임 중복 체크 - 닉네임이 존재하는 경우") void testIsNicknameTaken_NicknameExists() { String existingNickname = "existingNick"; - when(userRepository.existsByNickname(existingNickname)).thenReturn(true); - boolean isTaken = userService.isNicknameTaken(existingNickname); + when(userRepository.existsByNickname(existingNickname)).thenReturn(true); + boolean isTaken = nicknameService.isNicknameTaken(existingNickname); assertThat(isTaken).isTrue(); } @@ -48,10 +48,9 @@ void testIsNicknameTaken_NicknameExists() { }) @DisplayName("닉네임 유효성 검사 테스트") void testIsInvalidNickname(String nickname, boolean expectedResult) { - boolean isValid = userService.isInvalidNickname(nickname); + + boolean isValid = nicknameService.isInvalidNickname(nickname); assertThat(isValid).isEqualTo(expectedResult); } - - -} +} \ No newline at end of file