Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group type by field #14

Merged
merged 8 commits into from
Aug 8, 2018
Merged

Group type by field #14

merged 8 commits into from
Aug 8, 2018

Conversation

andriyun
Copy link
Contributor

@andriyun andriyun commented May 9, 2018

Fix issue with wrong group membership settings
In case when the same group type used for Organizations(Departments) and the rest type of groups.

Should be merged after
#13

@andriyun andriyun requested a review from juuliabellcom May 9, 2018 16:56
@andriyun
Copy link
Contributor Author

andriyun commented May 9, 2018

@juuliabellcom please review changes
and test if it's possible for faxe, fredericia, odsherred

Copy link
Contributor

@juuliabellcom juuliabellcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, tested on faxe fredericia, odsherred

@andriyun andriyun requested a review from stankut May 14, 2018 13:10
@andriyun
Copy link
Contributor Author

@stanbellcom Please
Could you review the changes also?
I want to be sure that we are not going to add regressions there

@dsbellcom dsbellcom merged commit fcc549c into master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants