Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file usage is unclear #27

Open
Mohd2493 opened this issue Jan 3, 2024 · 2 comments
Open

Config file usage is unclear #27

Mohd2493 opened this issue Jan 3, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@Mohd2493
Copy link

Mohd2493 commented Jan 3, 2024 •
edited by GalenReich
Loading

does anyone have an example config file layout

File name of configuration file to store TikTok credentials to
@GalenReich GalenReich added the documentation Improvements or additions to documentation label Jan 8, 2024
@GalenReich
Copy link
Contributor

Hi Mohd2493, thanks for opening this issue. Currently, the configuration file argument is not used by the tool and is incorrectly documented.

@GalenReich
Copy link
Contributor

Currently, the readme and argparse include a config parameter that is unused by the tool:

--config CONFIG File name of configuration file to store TikTok credentials to

The argument is passed to TikTokDownloader, but is not used.

tiktok-hashtag-analysis/tiktok_hashtag_analysis/base.py

Line 143 in 18e2c4d

self, hashtags: List[str], data_dir: Path, config_file: Optional[str] = None

Looks like Authorization was removed from here in #22 as unneeded. @trislee can this be removed safely?

@GalenReich GalenReich changed the title does anyone have an example config file layout Config file usage is unclear Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalenReich @Mohd2493