Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor atomic reactions to match ADAS reactions #278

Open
mikekryjak opened this issue Dec 9, 2024 · 0 comments
Open

Refactor atomic reactions to match ADAS reactions #278

mikekryjak opened this issue Dec 9, 2024 · 0 comments
Labels
confusing Something in the code or documentation could be more clear

Comments

@mikekryjak
Copy link
Collaborator

Hydrogenic reactions have been implemented in a confusing way where ionisation, recombination and charge exchange are separate files and have an object hierarchy that is pretty hard to follow.

ADAS reactions for impurities were implemented at a later stage and are much clearer. We should refactor the hydrogenic reactions in a similar way.
@mikekryjak mikekryjak added the confusing Something in the code or documentation could be more clear label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confusing Something in the code or documentation could be more clear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikekryjak