Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to preview images in tmux #22

Closed
BigBrotherJu opened this issue Apr 3, 2024 · 4 comments · Fixed by #39
Closed

Ability to preview images in tmux #22

BigBrotherJu opened this issue Apr 3, 2024 · 4 comments · Fixed by #39

Comments

@BigBrotherJu
Copy link

Image preview in tmux is doable for kitty using unicode placeholder, not sure about other terminal emulators.

Currently, tmux(3.4) image preview is not working in joshuto(0.9.8)+kitty(0.33.1). The preview column does not display anything.

@benjajaja
Copy link
Owner

Should work with #19, I will make a PR on joshuto.

@benjajaja
Copy link
Owner

made a PR kamiyaa/joshuto#553

@ErrorNoInternet
Copy link

Hi, I'm still not seeing anything in tmux 3.4 + kitty 0.36.1 on the main branch (297efaa75f082fee3d6741f53370fd00782e5244) of joshuto and iamb 0.0.10.

When I select a message in iamb, the image gets highlighted too, but I still can't see the actual image.

image

@benjajaja benjajaja reopened this Aug 29, 2024
@Nemo157
Copy link
Contributor

Nemo157 commented Sep 4, 2024

I think the \x1bPtmux etc. modifications need to be applied to the string generated in kitty::transmit_virtual, at least it looks like kitten icat is doing something similar when I inspect its output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants