Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activation of Responsive Images does not apply to carousel in 12.0.1 #1075

Open
sheydin opened this issue Aug 30, 2021 · 0 comments · May be fixed by #1159
Open

Activation of Responsive Images does not apply to carousel in 12.0.1 #1075

sheydin opened this issue Aug 30, 2021 · 0 comments · May be fixed by #1159

Comments

@sheydin
Copy link

sheydin commented Aug 30, 2021 •
edited
Loading

Hi,

the new bootstrap_package version 12.0.1 the activation of responsive images does not work with carousel anymore with this

// Enable Responsive Images

lib.contentElement.settings.responsiveimages.variants {
    default {
        sizes {
            1\.5x {
                multiplier = 1.5
            }
            2x {
                multiplier = 2
            }
        }
    }
}

What did change?

Thanks
@sheydin sheydin changed the title Activation of Responsive Image has no effect in 12.0.1 Activation of Responsive Images does not apply to carousel in 12.0.1 Aug 30, 2021
jonasesr added a commit to theissenmediengruppe/bootstrap_package that referenced this issue Apr 13, 2022
@jonasesr
FIX: benjaminkott#1075 Image multiplier loop in ImageVariantsUtility.php
5e6dbd4 
Loop over variants and apply the right multiplier instead of looping over variants.
@jonasesr jonasesr linked a pull request Apr 13, 2022 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: #1075 Image multiplier loop in ImageVariantsUtility.php theissenmediengruppe/bootstrap_package
1 participant
@sheydin