-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ifd_maker_note
may raise error if exif_file.make is not set yet
#21
Comments
A possible workaround is just skip this section. def ifd_maker_note(e, offset, exif_file, mode, data):
try:
exif_file.make
except AttributeError:
msg = "Haven't got make yet. Skipping."
raise JpegFile.SkipTag(msg)
# ...
end |
I confirm the above fix works |
christophlingg
added a commit
to komoot/pexif
that referenced
this issue
Nov 4, 2016
as pointed out bennoleslie#21
It would be cool if this could be put on pypi. But it is cool anyway that the fix is here to apply manually :) |
Is anyone addressing this? I can confirm that christophlingg's code in commit |
Thanks for the fix, would be great to have this fix released. Meanwhile we have to 🐒 patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a possibility that
MakerNote
section is in front ofMake
section, which will raise an exception as follows:AttributeError: ExifSegment instance has no attribute 'make'
Example photo links:
http://d3drsuq3xbnvq3.cloudfront.net/jp/pictures/201501/536906316/61e48289a1854983abba557ec1c6724c.jpeg
http://d3drsuq3xbnvq3.cloudfront.net/jp/pictures/201507/536906316/212a0c03410f5ed53c0ff8150216b10a.jpeg
The text was updated successfully, but these errors were encountered: