Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure tis secret for network layer #87

Open
zifeo opened this issue Dec 29, 2022 · 3 comments · May be fixed by #116
Open

Ability to configure tis secret for network layer #87

zifeo opened this issue Dec 29, 2022 · 3 comments · May be fixed by #116

Comments

@zifeo
Copy link

zifeo commented Dec 29, 2022

Currently, it does not seem to be able to set a secret for the ingress, and thus cert-manager cannot be used out of the box.

layers:
  network:
    ingressClass: nginx
    ingressAnnotations:
      cert-manager.io/cluster-issuer: letsencrypt
    ingressPath: /
    ingressPathType: ImplementationSpecific
    tls: true # ← suggested
@yetone
Copy link
Member

yetone commented Dec 30, 2022 •
edited
Loading

We already have a tls field in ingress: https://github.com/bentoml/yatai-deployment/blob/v1.0.x/helm/yatai-deployment/crds/bentodeployment.yaml#L2133

@zifeo
Copy link
Author

zifeo commented Dec 30, 2022 •
edited
Loading

@yetone thanks, I indeed saw the feature in the CRD but I would expect to be able to set an autogenerated name for all deployments in the chart. This ways, both CRD and GUI deployments will use that as a default.

@yetone
Copy link
Member

yetone commented Dec 30, 2022

@zifeo Good point, thanks for the suggestion, I will add this feature as soon as possible

@rauerhans rauerhans linked a pull request May 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default TLS for BentoDeployment model servers pluralsh/yatai-deployment
2 participants
@yetone @zifeo