Skip to content

Commit

Permalink
refactor: use the common build-arg parameter passing method
Browse files Browse the repository at this point in the history
  • Loading branch information
yetone committed Feb 4, 2025
1 parent 4af9182 commit 78724e8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions controllers/resources/bentorequest_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -3102,10 +3102,11 @@ echo "Done"
}

if imageStoredInS3 {
builderImage = "quay.io/bentoml/bento-image-builder:0.0.26"
builderImage = "quay.io/bentoml/bento-image-builder:0.1.0"
extraFlags := ""
for _, buildArg := range buildArgs {
extraFlags = fmt.Sprintf("%s --build-arg %s", extraFlags, strings.Replace(buildArg, "=", ":", 1))
quotedBuildArg := unix.SingleQuote.Quote(buildArg)
extraFlags = fmt.Sprintf("%s --build-arg %s", extraFlags, quotedBuildArg)
}
if !opt.ImageInfo.DockerRegistry.Secure {
extraFlags += " --image-registry-insecure"
Expand Down

0 comments on commit 78724e8

Please sign in to comment.