Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role binding for bento requests references incorrect yatai-system namespace #167

Open
nrlulz opened this issue Jan 2, 2025 · 0 comments

Comments

@nrlulz
Copy link

nrlulz commented Jan 2, 2025

Since updating to yatai-image-builder v1.2.55 I have encountered the following error when attempting to modify a bento deployment from yatai:

deploy deployment revision: failed to deploy kube bento deployment: failed to get kube bento request: bentorequests.resources.yatai.ai "bentorequest-name-here" is forbidden: User "system:serviceaccount:yatai-system:yatai" cannot get resource "bentorequests" in API group "resources.yatai.ai" in the namespace "yatai"

I have what I believe to be the default configuration - yatai and its service account live in the yatai-system namespace, and bentos are deployed to the yatai namespace. The role binding references a service account in the namespace where the bentorequest lives (yatai in this case), which doesn't exist. I believe it should point to the yatai-system namespace. It would happen to work as-is if everything were deployed to the same namespace. I have worked around this in the meantime by enabling bentoRequestAllNamespaces.

I'm guessing the change that needs made is something like this:

https://github.com/bentoml/yatai-image-builder/blob/v1.2.55/helm/yatai-image-builder/templates/rolebinding-yatai-with-bento-request.yaml#L14

  name: {{ $.Values.yataiSystem.serviceAccountName }}
-  namespace: {{ . | quote }}
+  namespace: {{ $.Values.yataiSystem.namespace | quote }}
{{- end }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant