-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording and position of "Display" and "Inline" in the web-UI. #314
Comments
It depends, as usual. The "problem" with "inline" is that it navigates to a view with no user interface and also that browser behaviour varies depending on file type. E.g. if you have a picture, it will only show the picture, but no UI with "download", "delete", etc. The missing UI is the main reason why this is not the default or "first link". I agree that "inline" is maybe not the best understandable wording - it comes from the implementation, that uses the https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition |
How about changing "Display" to "Preview" and "Inline" to "Open file" or "Open"? |
I don't see why Preview is better/different than Display. "Open" does not fit for the file types which the browser would just save to the Download folder. |
Mostly for 2 reasons:
It will be far more understandable what will happen after clicking/tapping on it, though. Also: Apparently, on GitHub, CTRL + Return instantly submits a comment without asking for confirmation, so i sent a draft of this comment unintentionally. |
We can look at how github does this: text filehttps://github.com/bepasty/bepasty-server/blob/master/AUTHORS
image (svg)https://github.com/bepasty/bepasty-server/blob/master/src/bepasty/static/app/bepasty.svg
https://github.com/pdf-association/pdf20examples/blob/master/Simple%20PDF%202.0%20file.pdf
binary (can't be rendered by browser)https://github.com/borgbackup/borg/blob/master/src/borg/testsuite/archiver/repo12.tar.gz
|
Yeah, guess it could be:
"Info" would indicate that it also shows related metadata of the file (but would not necessarily imply that it tries to show a preview also). "Info & Preview" maybe? Or "Details"? BTW, had a look at the code:
So the download/inline labels directly correspond to the URL (having The views:
So, So, the code and URLs are somewhat consistent. |
Yup, that is what i was imagining. :)
It would probably be good to just change it to "preview" and "open" for now.
One could add I just noticed that "preview" would not work ideally with Bepasty-lists that are opened from another listing, because it is their intended view, and not just a preview. So, much, discussion, about, changing, two, words! 😆 |
Currently, "Display" opens a preview with technical information; while "Inline" opens the file directly.
When i upload multiple files and give someone a link to the list with them, they would either click the filename or the "Display"-link intuitively, which opens a page with technical information first, and a preview at the bottom (or a link to the file Bepasty cannot offer a preview for).
To many people, "Inline", which is what they probably should click on most of the time (to access the file directly), will not have a well understandable meaning in this context, which will likely result in many people ignoring it.
(I guess it means: "The link that is meant to be used in the same line as text.")
It would probably improve the usability of lists, if:
The text was updated successfully, but these errors were encountered: