Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify that ingress.spec.tls.secretName exists #199

Open
bergerx opened this issue Oct 18, 2021 · 0 comments
Open

verify that ingress.spec.tls.secretName exists #199

bergerx opened this issue Oct 18, 2021 · 0 comments
Labels
good first issue Good for newcomers template only Something that involves only go template changes

Comments

@bergerx
Copy link
Owner

bergerx commented Oct 18, 2021 •
edited
Loading

In some cases, the certificate for ingress may be missing and it fallbacks to the default certificate.

It would be good if we can catch these cases:

  • ingress should have a .spec.tls, or its TLS will be up to default ingress config
  • the .spec.tls[*].hosts fields exist without a secretName next to it, this will use the default ingress cert
  • the secret exists
  • the secret is type: kubernetes.io/tls
  • the secret has the right keys (tls.crt and tls.key): https://kubernetes.io/docs/concepts/services-networking/ingress/#tls

I pushed some stretch goals into #200
@bergerx bergerx added good first issue Good for newcomers template only Something that involves only go template changes labels Oct 18, 2021
@bergerx bergerx mentioned this issue Oct 18, 2021
Open
@bergerx bergerx moved this to To do in Template Improvements Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers template only Something that involves only go template changes
Projects
Template Improvements
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bergerx