Skip to content

Commit

Permalink
Merge pull request #6278 from shaneknapp/fix-deploy-workflow-edx
Browse files Browse the repository at this point in the history
[DH-301] remove gcloud auth stanza as its superfluous
  • Loading branch information
shaneknapp authored Sep 26, 2024
2 parents 785505f + 6103d5f commit 03832c1
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions .github/workflows/deploy-hubs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,6 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt
# - name: Auth to gcloud
# if: ${{ env.DEPLOY }}
# uses: google-github-actions/auth@v2
# with:
# credentials_json: ${{ secrets.GKE_KEY }}
# project_id: ${{ secrets.GCP_PROJECT_ID }}

- name: Install Google Cloud SDK
if: ${{ env.DEPLOY }}
uses: google-github-actions/setup-gcloud@v2
Expand Down Expand Up @@ -152,13 +145,6 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt
- name: Auth to gcloud
if: ${{ env.DEPLOY }}
uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GKE_KEY }}
project_id: ${{ secrets.GCP_PROJECT_ID }}

- name: Install Google Cloud SDK
if: ${{ env.DEPLOY }}
uses: google-github-actions/setup-gcloud@v2
Expand Down Expand Up @@ -196,4 +182,4 @@ jobs:
echo "Deploying single-user image and hub config to ${deployment}"
hubploy --verbose deploy --timeout 30m ${deployment} hub prod
echo
done < <(python .github/scripts/determine-hub-deployments.py --ignore edx)
done < <(python .github/scripts/determine-hub-deployments.py)

0 comments on commit 03832c1

Please sign in to comment.