From f87bc08c4b60adf5de6ad163dbc3a80d790de762 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 23 Aug 2024 14:31:38 -0700 Subject: [PATCH 1/2] fixing workflow to test again --- .github/workflows/deploy-node-placeholder.yaml | 2 +- node-placeholder/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-node-placeholder.yaml b/.github/workflows/deploy-node-placeholder.yaml index 1099d5ca7..31ab884e7 100644 --- a/.github/workflows/deploy-node-placeholder.yaml +++ b/.github/workflows/deploy-node-placeholder.yaml @@ -74,7 +74,7 @@ jobs: sops -d -i deployments/datahub/secrets/gke-key.json gcloud auth \ activate-service-account \ - --key-file deployments/datahub/secrets/gke-key.json \ + --key-file deployments/datahub/secrets/gke-key.json gcloud container clusters \ --region=us-central1 --project=ucb-datahub-2018 \ get-credentials spring-2024 diff --git a/node-placeholder/values.yaml b/node-placeholder/values.yaml index 8d485f037..2c3932b5b 100644 --- a/node-placeholder/values.yaml +++ b/node-placeholder/values.yaml @@ -143,7 +143,7 @@ nodePools: requests: # Some value slightly lower than allocatable RAM on the nodepool memory: 29247442944 - replicas: 1 + replicas: 0 dlab: nodeSelector: hub.jupyter.org/pool-name: dlab-pool From 6b23ddfe5f45d2eed2dbf006608903a10ce8d44b Mon Sep 17 00:00:00 2001 From: shane knapp Date: Fri, 23 Aug 2024 14:33:47 -0700 Subject: [PATCH 2/2] remove node-placeholder workflow entirely this time --- .circleci/config.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bc124d61f..eebc87736 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -799,14 +799,6 @@ workflows: branches: only: - prod - deploy-node-placeholder: - jobs: - - deploy-node-placeholder: - filters: - branches: - # We don't have staging / prod for our node placeholder pods - # So we deploy only when deploying staging - only: staging deploy-support: jobs: