From bd4120034a4b8e943a50a34dd265ce4a1ba66fbf Mon Sep 17 00:00:00 2001
From: Balaji Alwar <balajialwar@berkeley.edu>
Date: Mon, 1 Jul 2024 17:52:59 -0700
Subject: [PATCH] Making changes tovalues.yaml instead of hub specific config

---
 deployments/datahub/config/common.yaml |  6 ------
 hub/values.yaml                        | 13 +++++++++++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/deployments/datahub/config/common.yaml b/deployments/datahub/config/common.yaml
index 80be3aadd..5683e39bc 100644
--- a/deployments/datahub/config/common.yaml
+++ b/deployments/datahub/config/common.yaml
@@ -114,12 +114,6 @@ jupyterhub:
           c.QtPDFExporter.enabled = False
           c.PDFExporter.enabled = True
           c.QtPNGExporter.enabled = False
-      culling-config:
-        data:
-          # Allow jupyterlab option to show hidden files in browser
-          # https://github.com/berkeley-dsep-infra/datahub/issues/5825
-          ContentsManager:
-            allow_hidden: true
     memory:
       guarantee: 512M
       limit: 1G
diff --git a/hub/values.yaml b/hub/values.yaml
index 21b3fcdaf..aaae379aa 100644
--- a/hub/values.yaml
+++ b/hub/values.yaml
@@ -85,6 +85,19 @@ jupyterhub:
           HistoryManager:
             # We do not need to keep around history for IPython, and especially not on NFS
             enabled: false
+      jupyter_server_config.json:
+        mountPath: /usr/local/etc/jupyter/jupyter_server_config.json
+        # if a user leaves a notebook with a running kernel,
+        # the effective idle timeout will typically be cull idle timeout
+        # of the server + the cull idle timeout of the kernel,
+        # as culling the kernel will register activity,
+        # resetting the no_activity timer for the server as a whole
+        data:
+          # Allow JupyterLab to show the 'View -> Show Hidden Files' option
+          # in the menu. Defaults are not changed.
+          # https://github.com/jupyterlab/jupyterlab/issues/11304#issuecomment-945466766
+          ContentsManager:
+            allow_hidden: true
       culling-config:
         mountPath: /etc/jupyter/jupyter_notebook_config.json
         data: