Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to toggle 'show hidden files'? #5825

Closed
cboettig opened this issue Jun 29, 2024 · 6 comments · Fixed by #5830
Closed

Allow user to toggle 'show hidden files'? #5825

cboettig opened this issue Jun 29, 2024 · 6 comments · Fixed by #5830
Assignees

Comments

@cboettig
Copy link

Summary

In our course, ESPM-157, many features we would like to cover, including git, GitHub Actions, git lfs (used in huggingface), require access to hidden files. (besides, we generally want students to understand what a hidden file is and feel confident working with it). Historically we have used the RStudio editor, where this a dropdown on the File menu.

In Jupyterhub, it looks like turning this on involves some additional steps? https://jupyterlab.readthedocs.io/en/latest/user/files.html#displaying-hidden-files (I've tried toggling this in the settings editor menu, but it doesn't seem to have an effect.)

Acceptance criteria

Users can choose to show or hide hidden files (dot files) using the View menu, as described in https://jupyterlab.readthedocs.io/en/latest/user/files.html#displaying-hidden-files

Additional Notes

I know we have the vscode (OSS Code) editor available, which already supports this too, but I'm hoping to just stick with the JupyterLab interface for consistency & simplicity it offers....

@ryanlovett
Copy link
Collaborator

This is enabled in stat159 hub:

@cboettig
Copy link
Author

@ryanlovett thanks, that's great! I was looking for how to do this in values.yaml file and couldn't figure it out. Is this documented somewhere? extraFiles.culling-config.data doesn't seem like the most obvious path to find ContentsManager options...

@ryanlovett
Copy link
Collaborator

@cboettig I think Yuvi chose culling-config because that's the slug that references the file contents that gets mounted at /etc/jupyter/jupyter_notebook_config.json. At the time the contents contained configuration related to culling. This contents should probably be put in the file /etc/jupyter/jupyter_server_config.json instead since it impacts jupyter server. The slug should be named jupyter_server_config.json (like what 2i2c does) to make it clearer.

This particular config is documented in JupyterLab and jupyter server.

If someone else doesn't get to it, I can make a PR on Monday.

@balajialg
Copy link
Contributor

I just saw the conversation and created #5830 to address the changes listed here. Ryan - happy to close my PR incase you have specific changes in mind.

@ryanlovett
Copy link
Collaborator

Thanks for submitting that @balajialg ! I recommend the changes mentioned in #5825 (comment). (not using culling-config since it is misleading and using /etc/jupyter/jupyter_server_config.json as the filename -- see the 2i2c example)

@balajialg
Copy link
Contributor

balajialg commented Jul 2, 2024

Ah, thanks (my bad)! I just updated the PR with a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants