Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request update to R package patchwork for class ph142 #6349

Closed
paulamarm opened this issue Oct 9, 2024 · 7 comments
Closed

Request update to R package patchwork for class ph142 #6349

paulamarm opened this issue Oct 9, 2024 · 7 comments
Assignees
Labels
package-request Package addition request for a hub

Comments

@paulamarm
Copy link

paulamarm commented Oct 9, 2024

Package Name

patchwork

Hub URL

publichealth.datahub.berkeley.edu

Course Name

Introduction to Probability and Statistics in Biology and Public Health

Semester Details

Ongoing: Just needs update

Installation Deadline

Ideally as soon as possible to prevent the instructors from manually making the update every time they use it in materials for lecture!
Currently seeing the following errors appear:

## If you are getting an error message like the following:
# Error in Ops.data.frame(guide_loc, panel_loc) :
#'==' only defined for equally-sized data frames
## ... then the issue might be a stale version of the 'patchwork' library. 
## You may be able to clear it up by manually running the following *once*, and then restarting R:
remove.packages('patchwork')
install.packages('patchwork')

Thank you!

@paulamarm paulamarm added the package-request Package addition request for a hub label Oct 9, 2024
@paulamarm paulamarm changed the title Request update to R package Patchwork for class ph142 Request update to R package patchwork for class ph142 Oct 9, 2024
@felder
Copy link
Contributor

felder commented Oct 9, 2024

@paulamarm can you provide me with what I'd need to enter into the R console to produce your error?

@felder
Copy link
Contributor

felder commented Oct 9, 2024

@paulamarm also can you please confirm the version of patchwork you're requesting?

@balajialg
Copy link
Contributor

@paulamarm We figured out that cloning the PH142-fa24 github repository and launching the following notebook allowed us to reproduce the issue that you reported. We would appreciate sharing such test cases as part of the request since it takes a lot of admin time to reproduce the issue with minimal information provided. In addition, we were unclear about the version that the package needs to get upgraded to (we eventually figured that it was version 1.3.0)

@shaneknapp
Copy link
Contributor

shaneknapp commented Oct 9, 2024

built, tested and about to merge to prod:

> packageVersion('patchwork')
[1] ‘1.3.0’

#6356

@felder
Copy link
Contributor

felder commented Oct 10, 2024

@paulamarm ok I actually made some significant changes to the image in order to fix a few other R packages that I noticed didn't install successfully as well as to update a number of components.

Details, if you're curious:
berkeley-dsep-infra/publichealth-user-image#5

I verified that the notebook @balajialg referenced earlier runs. However, I highly encourage you to run some additional tests using other notebooks to ensure no issues have popped up. If you'd like to do that, please login to https://publichealth-staging.datahub.berkeley.edu

@paulamarm
Copy link
Author

I apologize for not including the requested information in my initial post; I was following the package request template which didn't ask about recreating any errors, with the addition of details I got from course staff.
Thank you for the administrative support!

With the staging environment, I was able to run the notebooks used in the class without issues and can also see the update to Patchwork.

If there are any specific issues to be looking out for/testing with any specific notebooks, please let me know!
Thanks, Paula

@felder
Copy link
Contributor

felder commented Oct 10, 2024

@paulamarm ok this should land on prod shortly. People with running servers will need to restart them in order to get the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package-request Package addition request for a hub
Projects
None yet
Development

No branches or pull requests

4 participants