From 64800628acae7fb4c22369230815418b9987f46b Mon Sep 17 00:00:00 2001 From: shane knapp Date: Thu, 14 Dec 2023 14:42:12 -0800 Subject: [PATCH 01/18] bump z2jh to 3.2.1 --- hub/requirements.yaml | 2 +- images/hub/Dockerfile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hub/requirements.yaml b/hub/requirements.yaml index 345dc4fef..6ecdaf39d 100644 --- a/hub/requirements.yaml +++ b/hub/requirements.yaml @@ -4,5 +4,5 @@ dependencies: # get the helm chart version from here: https://github.com/jupyterhub/helm-chart # correlate the helm chart version w/jupyterhub here: # https://hub.jupyter.org/helm-chart/#development-releases-jupyterhub - version: 3.0.2 + version: 3.2.1 repository: https://jupyterhub.github.io/helm-chart/ diff --git a/images/hub/Dockerfile b/images/hub/Dockerfile index a45f330e4..54d4449ee 100644 --- a/images/hub/Dockerfile +++ b/images/hub/Dockerfile @@ -1,12 +1,12 @@ # Should match the hub image used by version of chart in hub/requirements.yaml # If that changes, this should be changed too! -FROM jupyterhub/k8s-hub:3.0.2 +FROM jupyterhub/k8s-hub:3.2.1 USER root RUN python3 -m pip install --no-cache git+https://github.com/berkeley-dsep-infra/canvasoauthenticator@09e7ed8 RUN python3 -m pip install --no-cache jupyterhub-ltiauthenticator==1.5.1 -RUN python3 -m pip install --no-cache git+https://github.com/jupyterhub/kubespawner@6.1.0 +#RUN python3 -m pip install --no-cache git+https://github.com/jupyterhub/kubespawner@6.1.0 RUN python3 -m pip install --no-cache jupyterhub-announcement COPY logos /srv/logos From c065c98896c2c82c36339da168c76d9f5667ce58 Mon Sep 17 00:00:00 2001 From: Balaji Alwar Date: Mon, 18 Dec 2023 15:23:54 -0800 Subject: [PATCH 02/18] Remove memory bumps during FA 23 --- deployments/data100/config/common.yaml | 3 --- deployments/data101/config/common.yaml | 6 ------ deployments/datahub/config/common.yaml | 16 ---------------- deployments/eecs/config/common.yaml | 7 ------- deployments/r/config/common.yaml | 5 ----- 5 files changed, 37 deletions(-) diff --git a/deployments/data100/config/common.yaml b/deployments/data100/config/common.yaml index 95f111eab..551d387eb 100644 --- a/deployments/data100/config/common.yaml +++ b/deployments/data100/config/common.yaml @@ -81,9 +81,6 @@ jupyterhub: # https://bcourses.berkeley.edu/courses/1524699/groups#tab-80607 course::1524699::group::all-admins: admin: true - course::1527426::group::Content: - mem_limit: 4G - mem_guarantee: 4G admin: mem_limit: 4G mem_guarantee: 2G diff --git a/deployments/data101/config/common.yaml b/deployments/data101/config/common.yaml index c7ba4d55c..cf6a58eb5 100644 --- a/deployments/data101/config/common.yaml +++ b/deployments/data101/config/common.yaml @@ -209,12 +209,6 @@ jupyterhub: custom: group_profiles: - course::1528038::enrollment_type::teacher: - mem_limit: 4096M - mem_guarantee: 2048M - course::1528038::enrollment_type::ta: - mem_limit: 4096M - mem_guarantee: 2048M # DataHub Infrastructure staff # https://bcourses.berkeley.edu/courses/1524699/groups#tab-80607 course::1524699::group::all-admins: diff --git a/deployments/datahub/config/common.yaml b/deployments/datahub/config/common.yaml index 917b75dde..d1c15d06e 100644 --- a/deployments/datahub/config/common.yaml +++ b/deployments/datahub/config/common.yaml @@ -173,19 +173,3 @@ jupyterhub: mountPath: /home/jovyan/ugba-88 subPath: _shared/course/ugba-88 readOnly: true - course::1527534: # CE 103N, Fall 2023, issue #4999 - mem_limit: 4096M - mem_guarantee: 4096M - course::1528163: # Demog 180, Fall 2023, issue #5004 - mem_limit: 4096M - mem_guarantee: 4096M - course::1524680: # UGBA88, Fall 2023, issue #5071 - mem_limit: 3072M - mem_guarantee: 3072M - course::1527878: # Music 30, Fall 2023, issue #5153 - mem_limit: 2048M - mem_guarantee: 2048M - # Econ 144, Fall 2023, issue #5161 - course::1530164::enrollment_type::teacher: - mem_limit: 2048M - mem_guarantee: 2048M diff --git a/deployments/eecs/config/common.yaml b/deployments/eecs/config/common.yaml index 6c2b2bee5..e3f97d068 100644 --- a/deployments/eecs/config/common.yaml +++ b/deployments/eecs/config/common.yaml @@ -84,10 +84,3 @@ jupyterhub: guarantee: 0.1 image: {} - # read by z2jh.get_config() in hub/values.yaml - # formerly jupyterhub.hub.extraConfigMap - custom: - group_profiles: - course::1527328: # EE 120, Fall 2023, issue #4868 - mem_limit: 4096M - mem_guarantee: 4096M diff --git a/deployments/r/config/common.yaml b/deployments/r/config/common.yaml index 3798491f4..6a600b489 100644 --- a/deployments/r/config/common.yaml +++ b/deployments/r/config/common.yaml @@ -78,8 +78,3 @@ jupyterhub: limit: 1G image: {} - custom: - group_profiles: - course::1527100: # ESPM 157, Fall 2023, issue #4822 - mem_limit: 4096M - mem_guarantee: 4096M From 9224db11040bcda5d307629164b0668bfd87a0a8 Mon Sep 17 00:00:00 2001 From: sean-morris Date: Mon, 18 Dec 2023 15:54:10 -0800 Subject: [PATCH 03/18] [edx] Update Otter-Submit Button --- deployments/edx/image/environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployments/edx/image/environment.yml b/deployments/edx/image/environment.yml index 5592c0032..97ea63d23 100644 --- a/deployments/edx/image/environment.yml +++ b/deployments/edx/image/environment.yml @@ -46,5 +46,5 @@ dependencies: - gh-scoped-creds==4.1 - git+https://github.com/shaneknapp/python-popularity-contest.git@add-error-handling - otter-grader==4.4.1 - - otter-submit==0.1.1 + - otter-submit==0.1.2 - sympy==1.12 From 0737cac1a1c9b5ac2ce9a7476b5982d9a659cc37 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 10:23:12 -0800 Subject: [PATCH 04/18] chartpressed --- hub/Chart.yaml | 2 +- hub/values.yaml | 2 +- node-placeholder/Chart.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hub/Chart.yaml b/hub/Chart.yaml index 798f6ed83..cf690a5c0 100644 --- a/hub/Chart.yaml +++ b/hub/Chart.yaml @@ -2,4 +2,4 @@ apiVersion: v1 appVersion: '1.0' description: Deployment Chart for JupyterHub name: hub -version: 0.0.1-0.dev.git.7076.heb3ce9bd +version: 0.0.1-0.dev.git.7126.h64800628 diff --git a/hub/values.yaml b/hub/values.yaml index be76b0bf5..b0beb26b4 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -219,7 +219,7 @@ jupyterhub: # Generated by chartpress image: name: gcr.io/ucb-datahub-2018/jupyterhub-hub - tag: '0.0.1-0.dev.git.7076.heb3ce9bd' + tag: '0.0.1-0.dev.git.7126.h64800628' networkPolicy: enabled: true ingress: diff --git a/node-placeholder/Chart.yaml b/node-placeholder/Chart.yaml index c88aa2a2f..60bba109e 100644 --- a/node-placeholder/Chart.yaml +++ b/node-placeholder/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.1-0.dev.git.6958.h1afe4805 +version: 0.0.1-0.dev.git.7077.h95e09b06 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to From ba834414a6a23813c14ced23380c15dcaa0d2dbc Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:24:17 -0800 Subject: [PATCH 05/18] bump prom --- support/requirements.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/requirements.yaml b/support/requirements.yaml index 429126816..e4bba9c0d 100644 --- a/support/requirements.yaml +++ b/support/requirements.yaml @@ -3,7 +3,7 @@ dependencies: version: 0.5.0 repository: https://prometheus-community.github.io/helm-charts - name: prometheus - version: 15.12.0 + version: 25.8.2 repository: https://prometheus-community.github.io/helm-charts - name: grafana version: 6.57.4 From 47461e5daf7b24ad7a5ffa4ae06624843400587f Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:33:05 -0800 Subject: [PATCH 06/18] bump helm to unstick latest prom helm chart --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c56ebe27e..f59caa451 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -155,7 +155,7 @@ jobs: - run: name: Install helm3 command: | - curl -L https://get.helm.sh/helm-v3.6.3-linux-amd64.tar.gz | \ + curl -L https://get.helm.sh/helm-v3.13.3-linux-amd64.tar.gz | \ tar -xzf - mv linux-amd64/helm /usr/local/bin helm repo add jupyterhub https://jupyterhub.github.io/helm-chart/ From 9d21844ea291a20fc2c2e7b25f771cd09099d4f8 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:34:12 -0800 Subject: [PATCH 07/18] get all the helms --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f59caa451..d24d4cbf2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -338,7 +338,7 @@ jobs: - run: name: Setup helm3 command: | - curl -L https://get.helm.sh/helm-v3.5.4-linux-amd64.tar.gz | \ + curl -L https://get.helm.sh/helm-v3.13.3-linux-amd64.tar.gz | \ tar -xzf - mv linux-amd64/helm /usr/local/bin helm repo add prometheus-community https://prometheus-community.github.io/helm-charts @@ -404,7 +404,7 @@ jobs: - run: name: Setup helm3 command: | - curl -L https://get.helm.sh/helm-v3.6.3-linux-amd64.tar.gz | \ + curl -L https://get.helm.sh/helm-v3.13.3-linux-amd64.tar.gz | \ tar -xzf - mv linux-amd64/helm /usr/local/bin helm repo add prometheus-community https://prometheus-community.github.io/helm-charts From 163c48de2cfdab17914c69eaebf149a524e0297d Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:44:18 -0800 Subject: [PATCH 08/18] it's turtles all the way down --- .circleci/config.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d24d4cbf2..b816edac1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -57,7 +57,7 @@ orbs: - run: name: Install google cloud sdk command: | - export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-363.0.0-linux-x86_64.tar.gz + export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-457.0.0-linux-x86_64.tar.gz curl -sSL $GCLOUD_URL | tar -xzf - -C ${HOME} # Be careful with quote ordering here. ${PATH} must not be expanded # Don't use ~ here - bash can interpret PATHs containing ~, but most other things can't. @@ -66,6 +66,11 @@ orbs: # Try to tell cloud sdk to use python3 echo 'export CLOUDSDK_PYTHON=python3' >> ${BASH_ENV} + - run: + name: Install gcloud auth plugin + command: | + gcloud components install gke-gcloud-auth-plugin + - run: name: Configure credential helper for Google Artifact Registry command: | From 96bac86c782b3ea97e815f7ab502b2ff04891a6a Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:47:13 -0800 Subject: [PATCH 09/18] bump all the versions --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b816edac1..3b0a885ff 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -136,7 +136,7 @@ jobs: # Can be removed once https://github.com/docker/docker-py/issues/2225 is merged and released pip install --upgrade git+https://github.com/docker/docker-py.git@b6f6e7270ef1acfe7398b99b575d22d0d37ae8bf - export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-363.0.0-linux-x86_64.tar.gz + export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-457.0.0-linux-x86_64.tar.gz curl -sSL $GCLOUD_URL | tar -xzf - -C ${HOME} # Be careful with quote ordering here. ${PATH} must not be expanded # Don't use ~ here - bash can interpret PATHs containing ~, but most other things can't. @@ -333,7 +333,7 @@ jobs: - run: name: install google-cloud-sdk command: | - export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-363.0.0-linux-x86_64.tar.gz + export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-457.0.0-linux-x86_64.tar.gz curl -sSL $GCLOUD_URL | tar -xzf - -C ${HOME} # Be careful with quote ordering here. ${PATH} must not be expanded # Don't use ~ here - bash can interpret PATHs containing ~, but most other things can't. @@ -389,7 +389,7 @@ jobs: - run: name: install google-cloud-sdk command: | - export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-363.0.0-linux-x86_64.tar.gz + export GCLOUD_URL=https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-457.0.0-linux-x86_64.tar.gz curl -sSL $GCLOUD_URL | tar -xzf - -C ${HOME} # Be careful with quote ordering here. ${PATH} must not be expanded # Don't use ~ here - bash can interpret PATHs containing ~, but most other things can't. From 004385329eee240ffd62869c494843e917a3f943 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:50:41 -0800 Subject: [PATCH 10/18] add plugin install --- .circleci/config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3b0a885ff..7abd7d975 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -361,6 +361,7 @@ jobs: - run: name: Activate credentials for datahub cluster (fall-2019) command: | + gcloud components install gke-gcloud-auth-plugin sops -d -i deployments/datahub/secrets/gke-key.json gcloud auth \ activate-service-account \ @@ -417,6 +418,7 @@ jobs: - run: name: Activate credentials for datahub cluster (fall-2019) command: | + gcloud components install gke-gcloud-auth-plugin sops -d -i deployments/datahub/secrets/gke-key.json gcloud auth \ activate-service-account \ From 253c08e86defde32376b5d08b04a14334de36e47 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 11:58:09 -0800 Subject: [PATCH 11/18] statsd is old now it isn't --- support/requirements.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/requirements.yaml b/support/requirements.yaml index e4bba9c0d..59b012d16 100644 --- a/support/requirements.yaml +++ b/support/requirements.yaml @@ -1,6 +1,6 @@ dependencies: - name: prometheus-statsd-exporter - version: 0.5.0 + version: 0.26.0 repository: https://prometheus-community.github.io/helm-charts - name: prometheus version: 25.8.2 From 6c691a012afcfdbb5e8101765962f80352dbd449 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 12:03:34 -0800 Subject: [PATCH 12/18] fix statsd version --- support/requirements.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/requirements.yaml b/support/requirements.yaml index 59b012d16..0afd0f22d 100644 --- a/support/requirements.yaml +++ b/support/requirements.yaml @@ -1,6 +1,6 @@ dependencies: - name: prometheus-statsd-exporter - version: 0.26.0 + version: 0.11.0 repository: https://prometheus-community.github.io/helm-charts - name: prometheus version: 25.8.2 From 7e0663a3854255c243e67dffe720c0b1c4d0705e Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 12:24:59 -0800 Subject: [PATCH 13/18] add helm debugging output --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7abd7d975..7801982ca 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -378,7 +378,7 @@ jobs: helm upgrade \ --install --wait \ --namespace=node-placeholder node-placeholder node-placeholder \ - -f node-placeholder/secrets.yaml + -f node-placeholder/secrets.yaml --debug deploy-support: docker: @@ -437,7 +437,7 @@ jobs: --install --wait \ --namespace=support \ support support/ \ - -f support/secrets.yaml + -f support/secrets.yaml --debug workflows: version: 2 From 350344461f59df800cf49e81d5c04f83a97264c9 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 12:35:20 -0800 Subject: [PATCH 14/18] comment out grafana --- .circleci/config.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7801982ca..70737c189 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -173,10 +173,12 @@ jobs: export PULL_REQUEST_ID=$(git log -1 --pretty=%B | head -n1 | sed 's/^.*#\([0-9]*\).*/\1/') export AUTHOR_NAME="$(git log -1 --pretty=%aN)" export PULL_REQUEST_TITLE="$(git log --pretty=%B -1 | tail -n+3)" - python3 scripts/post-grafana-annotation.py \ - --grafana-url http://grafana.datahub.berkeley.edu\ - --tag deployment-start \ - "$(echo -en ${PULL_REQUEST_TITLE}\\n\\n${AUTHOR_NAME}: https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/pull/${PULL_REQUEST_ID})" + + # added by sknapp 2023-12-19 to unblock builds + # python3 scripts/post-grafana-annotation.py \ + # --grafana-url http://grafana.datahub.berkeley.edu\ + # --tag deployment-start \ + # "$(echo -en ${PULL_REQUEST_TITLE}\\n\\n${AUTHOR_NAME}: https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/pull/${PULL_REQUEST_ID})" - run: name: Deploy a11y From d5668758ab78b73f5f807f9912579a21ab0e6981 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 12:45:01 -0800 Subject: [PATCH 15/18] authenticate properly during deploy --- .circleci/config.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 70737c189..c3ea248bc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -122,9 +122,9 @@ jobs: # Download and cache dependencies - restore_cache: keys: - - v3.9-dependencies-gcloud-363-{{ checksum "requirements.txt" }} + - v3.9-dependencies-gcloud-457-{{ checksum "requirements.txt" }} # fallback to using the latest cache if no exact match is found - - v3.9-dependencies-gcloud-363- + - v3.9-dependencies-gcloud-457- - run: name: install dependencies @@ -149,7 +149,7 @@ jobs: - save_cache: paths: - ./venv - key: v3.9-dependencies-gcloud-363-{{ checksum "requirements.txt" }} + key: v3.9-dependencies-gcloud-457-{{ checksum "requirements.txt" }} - run: name: Authenticating with google service account for kms/sops @@ -179,6 +179,10 @@ jobs: # --grafana-url http://grafana.datahub.berkeley.edu\ # --tag deployment-start \ # "$(echo -en ${PULL_REQUEST_TITLE}\\n\\n${AUTHOR_NAME}: https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/pull/${PULL_REQUEST_ID})" + - run: + name: Install gcloud auth plugin + command: | + gcloud components install gke-gcloud-auth-plugin - run: name: Deploy a11y From 3658bd1127b3cb13588c77a1fbdc620a770d40c9 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 13:43:35 -0800 Subject: [PATCH 16/18] trying this --- .circleci/config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c3ea248bc..aa0086e43 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -443,7 +443,8 @@ jobs: --install --wait \ --namespace=support \ support support/ \ - -f support/secrets.yaml --debug + -f support/secrets.yaml \ + --set installCRDs=true --debug workflows: version: 2 From f4e3d1e13c1b9d387682beee07d991fe667d21b8 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 14:17:34 -0800 Subject: [PATCH 17/18] bump cert-manager --- support/requirements.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/requirements.yaml b/support/requirements.yaml index 0afd0f22d..f15c30488 100644 --- a/support/requirements.yaml +++ b/support/requirements.yaml @@ -9,7 +9,7 @@ dependencies: version: 6.57.4 repository: https://grafana.github.io/helm-charts - name: cert-manager - version: v1.9.1 + version: v1.13.3 repository: https://charts.jetstack.io - name: ingress-nginx version: 4.8.3 From f10aaf24cd5e59e6cb5a51a2cc0dca1ef58cc65d Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 19 Dec 2023 15:13:10 -0800 Subject: [PATCH 18/18] maybe unstick builds --- support/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/values.yaml b/support/values.yaml index b0e5914ab..430d24f8b 100644 --- a/support/values.yaml +++ b/support/values.yaml @@ -1,7 +1,7 @@ cert-manager: nodeSelector: hub.jupyter.org/pool-name: support-pool - installCRDs: true + # installCRDs: true cainjector: nodeSelector: hub.jupyter.org/pool-name: support-pool