Making node-pools command more general & match to clusters command #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
LGTM! thanks for doing this! |
|
greg, please use a feature branch, rather than pushing to your fork's |
|
Whoops, I goofed! |
|
Now here, bundled w/ Deployment scripts & configs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to get the specific, current production cluster name out of the second sample command (the
gcloud container node-pools createcommand). This also matches the fill-in-the-blank syntax<cluster-name>in the immediately-previousgcloud container clusters createcommand.Better to have the second command error out on the placeholder name rather than unintentionally deploying the new node pool in the
spring-2024cluster when not intended.