From d5db7b58980a8bd9399070eccbc038dae04ff23a Mon Sep 17 00:00:00 2001 From: Balaji Alwar Date: Mon, 1 Jul 2024 16:57:55 -0700 Subject: [PATCH 1/3] Add support for hidden files in Datahub --- deployments/datahub/config/common.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/deployments/datahub/config/common.yaml b/deployments/datahub/config/common.yaml index 5683e39bc..80be3aadd 100644 --- a/deployments/datahub/config/common.yaml +++ b/deployments/datahub/config/common.yaml @@ -114,6 +114,12 @@ jupyterhub: c.QtPDFExporter.enabled = False c.PDFExporter.enabled = True c.QtPNGExporter.enabled = False + culling-config: + data: + # Allow jupyterlab option to show hidden files in browser + # https://github.com/berkeley-dsep-infra/datahub/issues/5825 + ContentsManager: + allow_hidden: true memory: guarantee: 512M limit: 1G From bd4120034a4b8e943a50a34dd265ce4a1ba66fbf Mon Sep 17 00:00:00 2001 From: Balaji Alwar Date: Mon, 1 Jul 2024 17:52:59 -0700 Subject: [PATCH 2/3] Making changes tovalues.yaml instead of hub specific config --- deployments/datahub/config/common.yaml | 6 ------ hub/values.yaml | 13 +++++++++++++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/deployments/datahub/config/common.yaml b/deployments/datahub/config/common.yaml index 80be3aadd..5683e39bc 100644 --- a/deployments/datahub/config/common.yaml +++ b/deployments/datahub/config/common.yaml @@ -114,12 +114,6 @@ jupyterhub: c.QtPDFExporter.enabled = False c.PDFExporter.enabled = True c.QtPNGExporter.enabled = False - culling-config: - data: - # Allow jupyterlab option to show hidden files in browser - # https://github.com/berkeley-dsep-infra/datahub/issues/5825 - ContentsManager: - allow_hidden: true memory: guarantee: 512M limit: 1G diff --git a/hub/values.yaml b/hub/values.yaml index 21b3fcdaf..aaae379aa 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -85,6 +85,19 @@ jupyterhub: HistoryManager: # We do not need to keep around history for IPython, and especially not on NFS enabled: false + jupyter_server_config.json: + mountPath: /usr/local/etc/jupyter/jupyter_server_config.json + # if a user leaves a notebook with a running kernel, + # the effective idle timeout will typically be cull idle timeout + # of the server + the cull idle timeout of the kernel, + # as culling the kernel will register activity, + # resetting the no_activity timer for the server as a whole + data: + # Allow JupyterLab to show the 'View -> Show Hidden Files' option + # in the menu. Defaults are not changed. + # https://github.com/jupyterlab/jupyterlab/issues/11304#issuecomment-945466766 + ContentsManager: + allow_hidden: true culling-config: mountPath: /etc/jupyter/jupyter_notebook_config.json data: From f5890ee30e19a098d1a617322d229f5b1aa6e95e Mon Sep 17 00:00:00 2001 From: Balaji Alwar Date: Tue, 2 Jul 2024 14:06:44 -0700 Subject: [PATCH 3/3] Removing comment about culling --- hub/values.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hub/values.yaml b/hub/values.yaml index aaae379aa..0efd1c28f 100644 --- a/hub/values.yaml +++ b/hub/values.yaml @@ -87,11 +87,6 @@ jupyterhub: enabled: false jupyter_server_config.json: mountPath: /usr/local/etc/jupyter/jupyter_server_config.json - # if a user leaves a notebook with a running kernel, - # the effective idle timeout will typically be cull idle timeout - # of the server + the cull idle timeout of the kernel, - # as culling the kernel will register activity, - # resetting the no_activity timer for the server as a whole data: # Allow JupyterLab to show the 'View -> Show Hidden Files' option # in the menu. Defaults are not changed.