From 8693e22429f6f9d70a6d47f9fae45dbe5b3f281a Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 24 Sep 2024 10:28:50 -0700 Subject: [PATCH 1/2] parens were causing this to quietly fail --- .github/scripts/determine-hub-deployments.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/scripts/determine-hub-deployments.py b/.github/scripts/determine-hub-deployments.py index cc4010bb7..6017c6b8a 100755 --- a/.github/scripts/determine-hub-deployments.py +++ b/.github/scripts/determine-hub-deployments.py @@ -18,10 +18,8 @@ def main(args): hubs = [] # Deploy all hubs by getting deployment names from the dirs in deployments/ - if ( - "GITHUB_PR_LABEL_JUPYTERHUB_DEPLOYMENT" or - "GITHUB_PR_LABEL_HUB_IMAGES" - ) in os.environ.keys(): + if "GITHUB_PR_LABEL_JUPYTERHUB_DEPLOYMENT" or \ + "GITHUB_PR_LABEL_HUB_IMAGES" in os.environ.keys(): for deployment in next(os.walk(args.deployments))[1]: if deployment not in args.ignore: hubs.append(deployment) From d693f72062e50b192a134f17fdad90776c62ed01 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Tue, 24 Sep 2024 10:43:27 -0700 Subject: [PATCH 2/2] truly fix this --- .github/scripts/determine-hub-deployments.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/determine-hub-deployments.py b/.github/scripts/determine-hub-deployments.py index 6017c6b8a..36bfecce9 100755 --- a/.github/scripts/determine-hub-deployments.py +++ b/.github/scripts/determine-hub-deployments.py @@ -18,7 +18,7 @@ def main(args): hubs = [] # Deploy all hubs by getting deployment names from the dirs in deployments/ - if "GITHUB_PR_LABEL_JUPYTERHUB_DEPLOYMENT" or \ + if "GITHUB_PR_LABEL_JUPYTERHUB_DEPLOYMENT" in os.environ.keys() or \ "GITHUB_PR_LABEL_HUB_IMAGES" in os.environ.keys(): for deployment in next(os.walk(args.deployments))[1]: if deployment not in args.ignore: