From a46cc4a42ea39ebad8f66f43c91e73180ebd955a Mon Sep 17 00:00:00 2001 From: Bernardo Guerreiro Date: Tue, 23 Jan 2024 17:42:55 +0000 Subject: [PATCH] refactor: fix inputs to workflow --- .github/workflows/serverless-deploy.yaml | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/.github/workflows/serverless-deploy.yaml b/.github/workflows/serverless-deploy.yaml index fdefef8..988fc19 100644 --- a/.github/workflows/serverless-deploy.yaml +++ b/.github/workflows/serverless-deploy.yaml @@ -41,7 +41,7 @@ jobs: deploy_to_env: runs-on: ubuntu-latest env: - ENVIRONMENT: ${{ github.event.inputs.ENVIRONMENT }} + ENVIRONMENT: ${{ inputs.ENVIRONMENT }} outputs: SERVICE_URL: ${{ steps.set_service_url.outputs.SERVICE_URL }} steps: @@ -59,22 +59,8 @@ jobs: role-to-assume: ${{ secrets.AWS_DEPLOYER_ROLE }} role-session-name: OIDCSession mask-aws-account-id: true - # - name: Serverless OIDC Login #https://github.com/thomasmichaelwallace/serverless-better-credentials?tab=readme-ov-file#troubleshooting - # run: | - # mkdir -p ~/.aws - # rm -rf ~/.aws/credentials - # echo "[default]" >> ~/.aws/credentials - # echo "aws_access_key_id = ${AWS_ACCESS_KEY_ID}" >> ~/.aws/credentials - # echo "aws_secret_access_key = ${AWS_SECRET_ACCESS_KEY}" >> ~/.aws/credentials - # echo "aws_session_token = ${AWS_SESSION_TOKEN}" >> ~/.aws/credentials - # echo "region = eu-west-2" >> ~/.aws/credentials - # echo "output = json" >> ~/.aws/credentials - # - name: Serverless Authentication - # run: npx serverless config credentials --provider aws --key ${{ env.AWS_ACCESS_KEY_ID }} --secret ${{ env.AWS_SECRET_ACCESS_KEY }} - name: serverless_deploy run: npm run deploy - # env: - # AWS_SDK_LOAD_CONFIG: 1 - name: seed_db if: ${{ inputs.SHOULD_SEED_DB == true }} run: npm run seed-db @@ -83,6 +69,4 @@ jobs: run: | SERVICE_URL="$(npx serverless info --verbose | grep ServiceEndpoint | sed s/ServiceEndpoint\:\ //g)" # echo "::add-mask::$SERVICE_URL" - echo "SERVICE_URL=$SERVICE_URL" >> "$GITHUB_OUTPUT" - # env: - # AWS_SDK_LOAD_CONFIG: 1 \ No newline at end of file + echo "SERVICE_URL=$SERVICE_URL" >> "$GITHUB_OUTPUT" \ No newline at end of file