From 690f2bf277b1c7d98debfef820aa534bf2a2bd40 Mon Sep 17 00:00:00 2001 From: Nick Reilingh Date: Sun, 21 May 2023 12:09:28 -0400 Subject: [PATCH 1/3] SetStatus docs proofreading and 'apropriate' typo --- lib/RT/Action/Autoreply.pm | 2 +- lib/RT/Action/SetStatus.pm | 20 ++++++++++---------- lib/RT/Group.pm | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/RT/Action/Autoreply.pm b/lib/RT/Action/Autoreply.pm index 2197aa343a6..18e2e869209 100644 --- a/lib/RT/Action/Autoreply.pm +++ b/lib/RT/Action/Autoreply.pm @@ -87,7 +87,7 @@ sub SetRecipients { =head2 SetReturnAddress -Set this message's return address to the apropriate queue address +Set this message's return address to the appropriate queue address =cut diff --git a/lib/RT/Action/SetStatus.pm b/lib/RT/Action/SetStatus.pm index 688a616c02b..ec7b5a2bcfe 100644 --- a/lib/RT/Action/SetStatus.pm +++ b/lib/RT/Action/SetStatus.pm @@ -60,7 +60,7 @@ RT::Action::SetStatus - RT's scrip action to set status of a ticket This action changes status to a new value according to the rules in L. Status is not changed if the transition is invalid or another error occurs. All -issues are logged at apropriate levels. +issues are logged at appropriate levels. =head1 ARGUMENT @@ -70,22 +70,22 @@ Argument can be one of the following: =item status literally -Status is changed from the current value to a new defined by the argument, -but only if it's valid status and allowed by transitions of the current lifecycle, -for example: +Status is changed from the current value to a new value defined by the argument, +but only if it is a valid status and allowed by the current lifecycle's +transitions, for example: * The current status is 'stalled' * Argument of this action is 'open' - * The only possible transition in the scheam from 'stalled' is 'open' - * Status is changed + * The lifecycle's only valid transition from 'stalled' is to 'open' + * Status is changed to 'open' -However, in the example above Status is not changed if argument is anything -else as it's just not allowed by the lifecycle. +However, in the example above Status is not changed if the argument is any other +literal status, since no other transitions are allowed by the lifecycle. =item 'initial', 'active' or 'inactive' -Status is changed from the current value to first possible 'initial', -'active' or 'inactive' correspondingly. First possible value is figured +Status is changed from the current value to the first possible 'initial', +'active', or 'inactive' status accordingly. First possible value is determined according to transitions to the target set, for example: * The current status is 'open' diff --git a/lib/RT/Group.pm b/lib/RT/Group.pm index d2fca4a6a5b..71cdcdcc3f2 100644 --- a/lib/RT/Group.pm +++ b/lib/RT/Group.pm @@ -1146,7 +1146,7 @@ sub HasMemberRecursively { =head2 DeleteMember PRINCIPAL_ID Takes the principal id of a current user or group. -If the current user has apropriate rights, +If the current user has appropriate rights, removes that GroupMember from this group. Returns a two value array. the first value is true on successful addition or 0 on failure. The second value is a textual status msg. From 10c3fe22c69320b599a6a7551183a1c175e94c00 Mon Sep 17 00:00:00 2001 From: Nick Reilingh Date: Sun, 21 May 2023 12:54:28 -0400 Subject: [PATCH 2/3] Added one more oxford comma --- lib/RT/Action/SetStatus.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/RT/Action/SetStatus.pm b/lib/RT/Action/SetStatus.pm index ec7b5a2bcfe..bc8d17d3134 100644 --- a/lib/RT/Action/SetStatus.pm +++ b/lib/RT/Action/SetStatus.pm @@ -90,7 +90,7 @@ according to transitions to the target set, for example: * The current status is 'open' * Argument of this action is 'inactive' - * Possible transitions from 'open' are 'resolved', 'rejected' or 'deleted' + * Possible transitions from 'open' are 'resolved', 'rejected', or 'deleted' * Status is changed to 'resolved' =back From ba831ff04bd328cb5019a44e8bfa6580ee96b2c1 Mon Sep 17 00:00:00 2001 From: Nick Reilingh Date: Sun, 21 May 2023 12:55:05 -0400 Subject: [PATCH 3/3] Another oxford comma --- lib/RT/Action/SetStatus.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/RT/Action/SetStatus.pm b/lib/RT/Action/SetStatus.pm index bc8d17d3134..1a4e0390617 100644 --- a/lib/RT/Action/SetStatus.pm +++ b/lib/RT/Action/SetStatus.pm @@ -82,7 +82,7 @@ transitions, for example: However, in the example above Status is not changed if the argument is any other literal status, since no other transitions are allowed by the lifecycle. -=item 'initial', 'active' or 'inactive' +=item 'initial', 'active', or 'inactive' Status is changed from the current value to the first possible 'initial', 'active', or 'inactive' status accordingly. First possible value is determined