Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest-httpbin #145

Open
sigmavirus24 opened this issue Oct 15, 2017 · 5 comments
Open

Use pytest-httpbin #145

sigmavirus24 opened this issue Oct 15, 2017 · 5 comments
Labels
Enhancement good first issue Tests

Comments

@sigmavirus24
Copy link
Collaborator

Ideally, this will get rid of some of our spurious test failures that occur from relying on httpbin.org and will make the test suite faster as we won't be going over the network, we'll just be using localhost (which is still slow but less slow than actually going over the network).
@hroncok
Copy link
Member

hroncok commented Oct 28, 2017

httpbin.org has fixed URL. pytest-httpbin has currently random port until kevin1024/pytest-httpbin#24 is fixed. This might turn to be a problem (not sure yet).

@sigmavirus24
Copy link
Collaborator Author

Why would that be a problem if we use the fixture? Requests hasn't had an issue with it.

@hroncok
Copy link
Member

hroncok commented Oct 28, 2017

I meant with URL based matchers.

@sigmavirus24
Copy link
Collaborator Author

And this is why I need your help 😆

@hroncok
Copy link
Member

hroncok commented Oct 29, 2017

BTW kevin1024/pytest-httpbin#24 is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement good first issue Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigmavirus24 @hroncok