Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain manipulation #3890

Open
RebelNode opened this issue Oct 28, 2024 · 11 comments
Open

Terrain manipulation #3890

RebelNode opened this issue Oct 28, 2024 · 11 comments
Labels
Bug Something isn't working Gadget Synced gameplay code

Comments

@RebelNode
Copy link
Collaborator

Description

terrain.480.mp4

You can manipulate terrain with building frames such that it affects unit passability in your favor in a match. This kind of manipulation should probably be prevented somehow. Maybe add a small local terrain restore command when a buildingframe decays or is destroyed just to undo the terrain flattening that happens upon placing a building frame.

https://discord.com/channels/549281623154229250/1300196979254628432/1300386398422958081 for higher quality video. But you probably get the idea from above.

Expected Behaviour

Player cannot gain gameplay advantage from manipulating the terrain with building frames.

Actual Behaviour

Player can gain gameplay advantage from manipulating the terrain with building frames.

Reproduction steps

See video above.

Other

No response

@RebelNode RebelNode added the Bug Something isn't working label Oct 28, 2024
@SethDGamre
Copy link
Collaborator

Would the ideal behavior be to restore terrain slowly over time after a building has been removed from the area?

@WatchTheFort
Copy link
Member

Or don't deform the terrain at all, and add a levelling pad under the building instead.

@SethDGamre
Copy link
Collaborator

Or don't deform the terrain at all, and add a levelling pad under the building instead.

how the heckin shoot do you propose to accomplish that? This is some hard coded engine behavior stuff innit?

@WatchTheFort
Copy link
Member

how the heckin shoot do you propose to accomplish that? This is some hard coded engine behavior stuff innit?

https://springrts.com/wiki/Gamedev:UnitDefs#levelGround

@SethDGamre
Copy link
Collaborator

Better, but would just mean the issue raised in OP just takes longer to do. Also means building structures on slightly bumpy terrain might take longer sometimes leading to player ???

Good to tag as a GDT issue?

@WatchTheFort
Copy link
Member

What do you mean? All it would be doing is instead of levelling the land, the building would have a cube underneath that fills in the void space. When the building dies, the cube dies, and the original terrain is right there.

Functionally, it would be no different than raising the terrain. The only possible issue is in cases where the building lowers the terrain.

@sprunk
Copy link
Collaborator

sprunk commented Oct 28, 2024

you could also just disallow building on ramps

@MeSaber
Copy link

MeSaber commented Oct 30, 2024

What do you mean? All it would be doing is instead of levelling the land, the building would have a cube underneath that fills in the void space. When the building dies, the cube dies, and the original terrain is right there.

Functionally, it would be no different than raising the terrain. The only possible issue is in cases where the building lowers the terrain.

Doesnt this raise an issue if you finish a factory and build a tank it wont be able to exit because steepness?

@MeSaber
Copy link

MeSaber commented Oct 30, 2024

you could also just disallow building on ramps

You can do these steep terrains with dgun alone and it would cause the same issue.

I actually liked Seths idea that terrain in time goes to normal instead of staying deformed all game. Digging with weapons (like nukes) is just meme anyway.

@SethDGamre SethDGamre added the Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) label Oct 31, 2024
@SethDGamre
Copy link
Collaborator

From GDT minutes:
"Terrain should restore after a building is removed instantly. This is so that structure explosions will partially cover the restoration. Ideally, a special effect of some kind should be added to reclaim events to do the same."

@SethDGamre SethDGamre added Gadget Synced gameplay code and removed Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) labels Nov 3, 2024
@AGUREX
Copy link

AGUREX commented Nov 6, 2024

If I may, I believe the root of the problem lies in the unconstrained manipulation of terrain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Gadget Synced gameplay code
Projects
None yet
Development

No branches or pull requests

6 participants