Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui_gridmenu arrows cause "Failed to load" errors #3925

Open
rekterakathom opened this issue Nov 11, 2024 · 3 comments
Open

gui_gridmenu arrows cause "Failed to load" errors #3925

rekterakathom opened this issue Nov 11, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@rekterakathom
Copy link

Description

gui_gridmenu.lua uses two different unicode arrows, neither of which exist in the font the game uses (Exo2-SemiBold I believe?), so the glyph fails to load and this throws an on-screen error message. The arrows are also both in different styles, though you can't see this ingame because they fail to load

The broken glyphs are:

Error messages:

  • [t=01:13:54.334499][f=0004406] [Font] Warning: [CFontTexture::LoadWantedGlyphs] Failed to load glyph 10229 after 5 font replacement attempts
  • [t=01:38:32.439724][f=0048749] [Font] Warning: [CFontTexture::LoadWantedGlyphs] Failed to load glyph 129050 after 5 font replacement attempts

Expected Behaviour

Only supported unicode characters should be used to avoid errors.

Actual Behaviour

Unicode characters that are not supported by the font are being used and users receive errors about the missing glyphs.

Reproduction steps

  • Glyph 10229 ( ⟵ ) - arrow to the left: Enter any submenu in the building menu. For example, at the start of a game enter the "Build" menu. Any building submenu that has the "Back" option will do.
  • Glyph 129050( 🠚 ) - arrow to the right: Enter any submenu that has multiple pages. For example, place down T1 bot lab -> build cons bot -> place down T2 bot lab -> open build options for T2 bot lab -> error. Any building submenu that has multiple pages will do.

Other

Fix proposals:

  1. Just remove the symbols completely. They don't work currently either and the menus look ok without them.
  2. Use "less"- or "greater than" symbols. In my opinion this looks pretty crude and I personally prefer option 1. These symbols are supported by Exo2-SemiBold
@rekterakathom rekterakathom added the Bug Something isn't working label Nov 11, 2024
@saurtron
Copy link
Contributor

Can't the glyphs be added to the font or maybe some "extra glyphs" font?

@WatchTheFort
Copy link
Member

@saurtron
Copy link
Contributor

saurtron commented Nov 15, 2024

Looks like the arrows don't show up generally because of some fontconfig glitch.

I made an engine PR that both fixes fallbacks for linux and makes the arrows show both on windows and linux (as long as proper fonts are installed). Check PR for more info and windows testing log link.

Btw the left arrow looks bad for everyone it will need to be tweaked, the other looks fine imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants