Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both afuses has damagemodifier #3946

Open
MeSaber opened this issue Nov 20, 2024 · 2 comments
Open

Both afuses has damagemodifier #3946

MeSaber opened this issue Nov 20, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@MeSaber
Copy link

MeSaber commented Nov 20, 2024

Description

Both factions Afus has damagemodifier of 0.95 but this isnt mentioned anywhere ingame afaik.

Expected Behaviour

HP ingame is what you have and calculates for, say if you wanna bomb.

Actual Behaviour

5% more hidden effective HP.

Reproduction steps

No response

Other

No response

@MeSaber MeSaber added the Bug Something isn't working label Nov 20, 2024
@saurtron
Copy link
Contributor

For what I can see this only gets applied for weapon damage, but not for collision damage, so changing it would have some effect in game.

https://github.com/beyond-all-reason/spring/blob/7363dbc54b55d309539b92c60245f88afd1f4e4a/rts/Sim/Units/Unit.cpp#L1295-L1306

If we want to keep it as is, as I assume, then the fix would be to actually show the armor value at unit listings, or adjusted hp like you say. Probably need the balance team to decide something.

@sprunk
Copy link
Collaborator

sprunk commented Nov 20, 2024

Engine should probably just apply the modifier to all damage because skipping it for collisions is very opaque. I had no idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants