Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module should default to 'latest' if no version is specified #106

Closed
danifr opened this issue Aug 24, 2016 · 3 comments
Closed

Module should default to 'latest' if no version is specified #106

danifr opened this issue Aug 24, 2016 · 3 comments

Comments

@danifr
Copy link

danifr commented Aug 24, 2016

It seems there is no major issue with latest versions #94
I'd be happy to start a PR.

Thoughts?

@kbon
Copy link

kbon commented Nov 22, 2016

Not only that, but we maintain our own RPM repositories. As such, the version we typically want is indeed "latest", without any RPM iteration specified. Currently we can't configure the Grafana module this way on our EL6 machines, as the mandatory rpm_iteration parameter is "1" by default. We can set version to "latest" and rpm_iteration to blank, but then the module tries to install version "latest-" which doesn't work at all.

In the end, we solved it by modifying install.pp:

          if ( $::grafana::rpm_iteration == '' ) {
            $real_rpm_ensure = $::grafana::version
          } else {
            $real_rpm_ensure = "${::grafana::version}-${::grafana::rpm_iteration}"
          }

          package { $::grafana::package_name:
            ensure  => $real_rpm_ensure,
            require => Package['fontconfig']
          }

If you create a pull request with a new version default to "latest", I'd suggest also including something like this.

@dhoppe
Copy link

dhoppe commented Dec 7, 2016

I think this has been fixed by voxpupuli#1.

@danifr
Copy link
Author

danifr commented Dec 8, 2016

Cool! Thanks! I'll move to the voxpupuli one

@danifr danifr closed this as completed Dec 8, 2016
bastelfreak added a commit to bastelfreak/puppet-grafana that referenced this issue May 20, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-grafana that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants