Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires Puppet >= 3.4.x but not stated in metadata.json ('contain' function) #51

Open
noroute opened this issue Aug 28, 2015 · 5 comments

Comments

@noroute
Copy link

noroute commented Aug 28, 2015

The module uses the 'contain' function introduced in Puppet 3.4.x but metadata.json states it runs with 3.x.

We're in an installation with 3.1.x so I'll look into if there's an easy way to backport.

@gakhov
Copy link

gakhov commented Oct 19, 2015

+1

@bfraser
Copy link
Owner

bfraser commented Oct 26, 2015

Hi @noroute thanks for the report! You are correct.

To ensure resource containment without use of the contain function, for versions of Puppet < 3.4.0, it would be necessary to use the anchor pattern as mentioned in Puppet Labs' language reference.

The puppetlabs/stdlib module is already used, so it would be fairly trivial to implement. I had perhaps naively assumed most users would be on a version of Puppet > 3.4.0 (it was released in December 2013), but would be happy to switch to use of the anchor pattern if this is a blocker.

Either way, I'll need to update the version requirement in metadata.json.

@jaredledvina
Copy link

Looks like the PR was merged, @noroute all good here?

@keyan
Copy link

keyan commented Mar 21, 2016

We are still on Puppet 3.3 and the contain usage is blocking us from using this module. Would you be open to a PR changing to the anchor pattern?

@dhoppe
Copy link

dhoppe commented Dec 7, 2016

I think this has been fixed by voxpupuli#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants