Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPLINTER to PyPI #44

Open
gablank opened this issue Sep 15, 2015 · 13 comments
Open

Add SPLINTER to PyPI #44

gablank opened this issue Sep 15, 2015 · 13 comments

Comments

@gablank
Copy link
Collaborator

gablank commented Sep 15, 2015

When the Python interface is done and working well (which is the case very soon), we should add SPLINTER to PyPI, the Python Package Index, so users can easily install and use it.

@bgrimstad
Copy link
Owner

setup.py added in 81a6a27

@VikingScientist
Copy link

Splinter has a name clash with splinter 0.7.7

@gablank
Copy link
Collaborator Author

gablank commented Nov 1, 2017

We are aware of the potential name collision, so we have reserved splinterpy on PyPI.

Thanks for the feedback, though!

@VikingScientist
Copy link

Oh, right you are. Then this issue is resolved? Should it not be closed then?

BTW: searching for "splinter" on PyPI gives this package a weight* of 4 which puts it at the 7.place on the page ranking. I would suggest using the word "splinter" somewhere in the summary field to raise this.

* Weight: Occurences of search term weighted by field (name, summary, keywords, description, author, maintainer).

@gablank
Copy link
Collaborator Author

gablank commented Nov 1, 2017

We're keeping this issue open because we're not pleased with the way we package the library on PyPI. We are bundling a precompiled version of the library along with the python files, meaning the install will not work for all configurations. The plan is to package the C++ and C source files, and compiling them in setup.py. We haven't gotten to that point yet because of a lack of time.

Thanks for the suggestion regarding the ranking, we will definitely do that.

@gablank
Copy link
Collaborator Author

gablank commented Nov 17, 2018

Version 4.0 of SPLINTER has now been uploaded to PyPI. I have also made sure to include "SPLINTER" in the description to increase our weight in the search rankings.

Note that in the current release on PyPI, only Linux x64 is supported, as I haven't had the time to compile the library on other operating systems / architectures.

@bgrimstad
Copy link
Owner

bgrimstad commented Nov 17, 2018 via email

@frederikfaye
Copy link

That pip install splinterpy is possible for Linux x86 users should probably be mentioned somewhere in splinter/docs/compile.md, as it is quite the time-saver.

@jayvdb
Copy link

jayvdb commented Jul 28, 2020

@bgrimstad
Copy link
Owner

Hi @jayvdb,

I believe the PyPI version to be from one of the latest commits in the develop-branch. It seems like we forgot to tag the related commit, which is causing some confusion for our users (see e.g. #122).

We had planned to merge develop and properly package a new release, but we never got around to it. If I remember correctly, we decided to just package the develop-branch code to make the most recent development available. Hoping we can package v4 properly soon (it requires us to compile for multiple platforms). Until then, I suppose you have to look at the latest commit in the develop-branch.

Perhaps @gablank can dig out the commit we used for v4.0.4.

@jayvdb
Copy link

jayvdb commented Jul 29, 2020

Ok, great, that explains it. I can see it at https://github.com/bgrimstad/splinter/tree/develop/python

I do hope that a v4.0.x can be tagged soon. I dont really need v4.0.4, if another release tag is created here on GitHub - that would suffice for me.

It seems there is not a lot of change happening at the moment. Given that the Python library is already called v4.0, and the wheel includes the linux DSO, it seems that v4.0 is already of the barn long ago, and any remaining task for v4 needs to be shifted to v4.1, or done post tagging.

fwiw, I need to re-do https://build.opensuse.org/package/show/science/splinter , renaming the python package to splinterpy (so I can create a new package for the real "splinter", which is now a dependency of pytest-splinter) , and I can only do that with the v4 codebase for the entire repo, as I need to build the C library on umpteen arch that openSUSE supports, otherwise the Python library wont pass its tests on those platforms.

I'll do some builds now using the develop branch to check it, and report back.

@jayvdb
Copy link

jayvdb commented Aug 1, 2020

I did a build at https://build.opensuse.org/package/show/home:jayvdb:branches:science/splinter ; havent tried to get tests running, but at least compilation is passing.

@gablank
Copy link
Collaborator Author

gablank commented Aug 5, 2020

Hello @jayvdb!

Sorry about the late response from me. You are right, not much has happened in this place lately. I'll have a look at this issue soon. I wasn't aware that the library has been packaged for OpenSUSE, that is awesome! Maybe I'll have a look at creating a package for pacman while I'm working on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants